From: "Martin-Éric Racine" <martin-eric.racine@iki.fi>
To: Andres Salomon <dilinger@queued.net>
Cc: Jens Rottmann <JRottmann@lippertembedded.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-geode@lists.infradead.org
Subject: Re: IRQF_TIMER | IRQF_SHARED ?
Date: Mon, 12 Dec 2011 23:00:01 +0200 [thread overview]
Message-ID: <CAPZXPQdOrFPVR5rQzg1+ZxhU-p9SotHNft85okunB0YmUFA2Xg@mail.gmail.com> (raw)
In-Reply-To: <20111212123131.502be350@queued.net>
12. joulukuuta 2011 22.31 Andres Salomon <dilinger@queued.net> kirjoitti:
> On Mon, 12 Dec 2011 16:41:25 +0100
> Jens Rottmann <JRottmann@LiPPERTEmbedded.de> wrote:
>> one of our customers tripped over the fact that the MFGPT driver
>> won't share its IRQ with anyone else. (MFGPT defaulted to same IRQ as
>> audio, MFGPT driver loaded first, audio fails.) *No big deal!* They
>> don't actually need MFGPT and will simply disable it. It just made me
>> wonder ...
>>
>> Why would it be such a bad idea to use IRQF_TIMER | IRQF_SHARED (see
>> patch below)? mfgpt_tick() already does properly return IRQ_NONE when
>> it feels unresponsible. I tested it with either driver loaded first
>> and it seemed to work (well, at least audio worked, don't know how to
>> explicitly test cs5535-clockevt).
>
> Just loading cs5535-clockevt should start the periodic timer. On my
> XO-1, IRQ 7 starts firing immediately.
Could it be a good idea to inform udev maintainers of this?
Martin-Éric
next prev parent reply other threads:[~2011-12-12 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:41 IRQF_TIMER | IRQF_SHARED ? Jens Rottmann
2011-12-12 20:31 ` Andres Salomon
2011-12-12 21:00 ` Martin-Éric Racine [this message]
2011-12-12 22:06 ` Andres Salomon
2011-12-12 23:38 ` Thomas Gleixner
2011-12-13 15:49 ` Jens Rottmann
2011-12-14 18:37 ` Jens Rottmann
2011-12-14 18:47 ` Andres Salomon
2011-12-21 15:42 ` [PATCH] cs5535-clockevt: don't ignore MFGPT on SMP-capable kernels Jens Rottmann
2012-01-11 10:10 ` Andres Salomon
2012-01-19 12:57 ` Jens Rottmann
2012-01-23 10:44 ` Andres Salomon
2011-12-21 16:37 ` IRQF_TIMER | IRQF_SHARED ? Jens Rottmann
2011-12-22 16:35 ` [PATCH] cs5535-clockevt: allow the MFGPT IRQ to be shared Jens Rottmann
2012-01-11 10:15 ` Andres Salomon
2012-01-30 13:51 ` [PATCH] cs5535-clockevt: don't ignore MFGPT on SMP-capable kernels Jens Rottmann
2012-01-30 13:59 ` [PATCH] cs5535-clockevt: allow the MFGPT IRQ to be shared Jens Rottmann
2012-02-06 8:20 ` [PATCH resend] cs5535-clockevt: don't ignore MFGPT on SMP-capable kernels Jens Rottmann
2012-02-06 8:23 ` [PATCH resend] cs5535-clockevt: allow the MFGPT IRQ to be shared Jens Rottmann
2011-12-19 14:32 ` "clockevents: Set noop handler in clockevents_exchange_device()" causes hang with cs5535-clockevt Jens Rottmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPZXPQdOrFPVR5rQzg1+ZxhU-p9SotHNft85okunB0YmUFA2Xg@mail.gmail.com \
--to=martin-eric.racine@iki.fi \
--cc=JRottmann@lippertembedded.de \
--cc=dilinger@queued.net \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).