From: Song Liu <liu.song.a23@gmail.com>
To: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Networking <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf/core.c - silence warning messages
Date: Mon, 28 Jan 2019 19:12:49 -0800 [thread overview]
Message-ID: <CAPhsuW7F0yoOdgF335uET-_j+KkNohRCmG7sseisBK+bpaQy4g@mail.gmail.com> (raw)
In-Reply-To: <9865.1548718516@turing-police.cc.vt.edu>
On Mon, Jan 28, 2019 at 3:35 PM <valdis.kletnieks@vt.edu> wrote:
>
> On Mon, 28 Jan 2019 09:18:45 -0800, Song Liu said:
> > On Sun, Jan 27, 2019 at 8:43 PM <valdis.kletnieks@vt.edu> wrote:
>
> > > The attached patch silences the warnings, because we *know* we're overwriting
> > > the default initializer. That leaves bpf/core.c with only 6 other warnings,
> > > which become more visible in comparison.
> >
> > My concern is that this will also mute the warning for other parts of
> > bpf/core.c.
>
> I checked and there weren't any warnings for other parts of the file. Also, this message
> doesn't even happen unless you build with W=1, which apparently happens so rarely
> that nobody else has submitted a patch.
>
> Is there a high likelihood that another overwrite of an initializer is going to
> be included in the source?
>
> > Maybe we should move bpf_opcode_in_insntable() to a separate file, and mute
> > warning for that file?
>
> Seems to be overkill - the intent of this patch was mostly to make the *other*
> warnings issued with W=1 more noticable.
Yeah, I also felt this might be overkill while asking initially.
Acked-by: Song Liu <songliubraving@fb.com>
next prev parent reply other threads:[~2019-01-29 3:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 4:11 [PATCH] bpf/core.c - silence warning messages valdis.kletnieks
2019-01-28 17:18 ` Song Liu
2019-01-28 23:22 ` Daniel Borkmann
2019-01-28 23:48 ` valdis.kletnieks
2019-01-28 23:54 ` Daniel Borkmann
2019-01-28 23:35 ` valdis.kletnieks
2019-01-29 3:12 ` Song Liu [this message]
2019-06-07 2:39 Valdis Klētnieks
2019-06-11 5:46 ` Andrii Nakryiko
2019-06-12 14:56 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW7F0yoOdgF335uET-_j+KkNohRCmG7sseisBK+bpaQy4g@mail.gmail.com \
--to=liu.song.a23@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).