From: Zi Yan <ziy@nvidia.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yang Shi <shy828301@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Mel Gorman <mgorman@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Michal Hocko <mhocko@suse.com>, Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH] mm,do_huge_pmd_numa_page: remove unnecessary TLB flushing code
Date: Tue, 20 Jul 2021 09:36:55 -0400 [thread overview]
Message-ID: <CD7E5D4E-5243-47AE-8EAB-F9E05E19D374@nvidia.com> (raw)
In-Reply-To: <20210720065529.716031-1-ying.huang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3023 bytes --]
On 20 Jul 2021, at 2:55, Huang Ying wrote:
> Before the commit c5b5a3dd2c1f ("mm: thp: refactor NUMA fault
> handling"), the TLB flushing is done in do_huge_pmd_numa_page() itself
> via flush_tlb_range().
>
> But after commit c5b5a3dd2c1f ("mm: thp: refactor NUMA fault
> handling"), the TLB flushing is done in migrate_pages() as in the
> following code path anyway.
>
> do_huge_pmd_numa_page
> migrate_misplaced_page
> migrate_pages
>
> So now, the TLB flushing code in do_huge_pmd_numa_page() becomes
> unnecessary. So the code is deleted in this patch to simplify the
> code. This is only code cleanup, there's no visible performance
> difference.
But we save a potential TLB flush here right? Maybe the if statement
is not a common case.
Anyway, LGTM, Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>
>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Cc: Yang Shi <shy828301@gmail.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Zi Yan <ziy@nvidia.com>
> ---
> mm/huge_memory.c | 26 --------------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index afff3ac87067..9f21e44c9030 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1440,32 +1440,6 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf)
> goto out;
> }
>
> - /*
> - * Since we took the NUMA fault, we must have observed the !accessible
> - * bit. Make sure all other CPUs agree with that, to avoid them
> - * modifying the page we're about to migrate.
> - *
> - * Must be done under PTL such that we'll observe the relevant
> - * inc_tlb_flush_pending().
> - *
> - * We are not sure a pending tlb flush here is for a huge page
> - * mapping or not. Hence use the tlb range variant
> - */
> - if (mm_tlb_flush_pending(vma->vm_mm)) {
> - flush_tlb_range(vma, haddr, haddr + HPAGE_PMD_SIZE);
> - /*
> - * change_huge_pmd() released the pmd lock before
> - * invalidating the secondary MMUs sharing the primary
> - * MMU pagetables (with ->invalidate_range()). The
> - * mmu_notifier_invalidate_range_end() (which
> - * internally calls ->invalidate_range()) in
> - * change_pmd_range() will run after us, so we can't
> - * rely on it here and we need an explicit invalidate.
> - */
> - mmu_notifier_invalidate_range(vma->vm_mm, haddr,
> - haddr + HPAGE_PMD_SIZE);
> - }
> -
> pmd = pmd_modify(oldpmd, vma->vm_page_prot);
> page = vm_normal_page_pmd(vma, haddr, pmd);
> if (!page)
> --
> 2.30.2
—
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2021-07-20 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 6:55 [PATCH] mm,do_huge_pmd_numa_page: remove unnecessary TLB flushing code Huang Ying
2021-07-20 13:36 ` Zi Yan [this message]
2021-07-20 14:25 ` Christian Borntraeger
2021-07-20 20:53 ` Yang Shi
2021-07-20 21:04 ` Zi Yan
2021-07-20 22:19 ` Yang Shi
2021-07-21 15:41 ` Sean Christopherson
2021-07-22 0:26 ` Huang, Ying
2021-07-22 7:36 ` Christian Borntraeger
2021-07-22 23:10 ` Huang, Ying
2021-07-23 0:03 ` Huang, Ying
2021-07-23 20:19 ` Andrew Morton
2021-07-20 20:48 ` Yang Shi
2021-07-20 22:21 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD7E5D4E-5243-47AE-8EAB-F9E05E19D374@nvidia.com \
--to=ziy@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=shy828301@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).