RE: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

[Anson Huang <anson.huang@nxp.com>]

Hi, Lothar

Best Regards!
Anson Huang

> -----Original Message-----
> From: Lothar Waßmann [mailto:LW@KARO-electronics.de]
> Sent: 2018年11月28日 17:04
> To: Anson Huang <anson.huang@nxp.com>
> Cc: a.zummo@towertech.it; alexandre.belloni@bootlin.com;
> robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com;
> will.deacon@arm.com; Aisheng DONG <aisheng.dong@nxp.com>; Andy Gross
> <andy.gross@linaro.org>; arnd@arndb.de; horms+renesas@verge.net.au;
> heiko@sntech.de; bjorn.andersson@linaro.org; enric.balletbo@collabora.com;
> amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net;
> shawnguo@kernel.org; linux-rtc@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller
> RTC support
> 
> Hi,
> 
> On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote:
> > Add i.MX8QXP system controller RTC support.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 9155d45..ef57db6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -433,4 +433,8 @@
> >  		#size-cells = <1>;
> >  		ranges = <0x5f000000 0x0 0x5f000000 0x1000000>;
> >  	};
> > +
> > +	rtc: rtc {
> > +		compatible = "nxp,imx8qxp-sc-rtc";
> > +	};
> >  };
> IMO this should be disabled by default.

This module is NOT depending on any board design, should it be enabled by default in soc dtsi?
Like wdog etc..

Anson.

> 
> 
> Lothar Waßmann