From: "Han, Nandor (GE Healthcare)" <nandor.han@ge.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Malinen, Semi (GE Healthcare)" <semi.malinen@ge.com>
Subject: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver
Date: Mon, 24 Apr 2017 13:53:15 +0000 [thread overview]
Message-ID: <DB6P101MB024681FFA568D7E03665FC08E61F0@DB6P101MB0246.NAMP101.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CACRpkdZHMWH2W-i4MGZ7NKzPHUURRmC-5YwiK7cVLCHKDsb7sw@mail.gmail.com>
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: 24 April 2017 16:47
> To: Han, Nandor (GE Healthcare) <nandor.han@ge.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>; David S. Miller <davem@davemloft.net>; Geert Uytterhoeven <geert@linux-
> m68k.org>; Mauro Carvalho Chehab <mchehab@kernel.org>; Daniel Vetter <daniel.vetter@ffwll.ch>; Alexandre Courbot
> <gnurou@gmail.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; linux-
> gpio@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Malinen, Semi (GE Healthcare)
> <semi.malinen@ge.com>
> Subject: EXT: Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver
>
> On Thu, Apr 13, 2017 at 12:27 PM, Nandor Han <nandor.han@ge.com> wrote:
>
> > This is a simple driver that provides a /sys/class/gpio
> > interface for controlling and configuring the GPIO lines.
> > It does not provide support for chip select or interrupts.
> >
> > Signed-off-by: Nandor Han <nandor.han@ge.com>
> > Signed-off-by: Semi Malinen <semi.malinen@ge.com>
>
> I almost want to make the driver depend on !GPIO_SYSFS because
> of this commit message.
>
> DO NOT USE OR ENCOURAGE THE USE OF THE GPIO SYSFS
> INTERFACE.
>
Ahh.. I forgot to change this commit message. Sorry I will change it ASAP.
> Use the character device.
>
> Use the example in tools/gpio/* as a guideline and testbed.
>
> Use libgpiod as a rich userspace.
>
> And the commit message should state that this is a driver
> for such and such Exar hardware instead.
>
> Thanks.
>
> > +#include <linux/bitops.h>
> > +#include <linux/gpio/driver.h>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/of_device.h>
> > +#include <linux/of_gpio.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/regmap.h>
>
> You are missing
> #include <linux/seq_file.h>
>
> and that is why the build robot is complaining.
>
I've noticed that. I will change it in the next rev.
> Yours,
> Linus Walleij
Thanks,
Nandy
next prev parent reply other threads:[~2017-04-24 13:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 10:27 [PATCH v2 0/4] XRA1403,gpio - add XRA1403 gpio expander driver Nandor Han
2017-04-13 10:27 ` [PATCH v2 1/4] dt-bindings: gpio - add exar to vendor prefixes list Nandor Han
2017-04-19 21:48 ` Rob Herring
2017-04-24 13:19 ` Linus Walleij
2017-04-13 10:27 ` [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Nandor Han
2017-04-13 16:22 ` kbuild test robot
2017-04-24 13:47 ` Linus Walleij
2017-04-24 13:53 ` Han, Nandor (GE Healthcare) [this message]
2017-04-25 7:07 ` Benjamin Henrion
2017-04-25 7:15 ` Geert Uytterhoeven
2017-04-26 17:50 ` Andy Shevchenko
2017-04-26 14:42 ` Linus Walleij
2017-04-13 10:27 ` [PATCH v2 3/4] doc,dts - add XRA1403 DTS binding documentation Nandor Han
2017-04-19 21:55 ` Rob Herring
2017-04-24 13:49 ` Linus Walleij
2017-04-13 10:27 ` [PATCH v2 4/4] Add XRA1403 support to MAINTAINERS file Nandor Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6P101MB024681FFA568D7E03665FC08E61F0@DB6P101MB0246.NAMP101.PROD.OUTLOOK.COM \
--to=nandor.han@ge.com \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=semi.malinen@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).