From: "Joshi, Mukul" <Mukul.Joshi@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Kasiviswanathan, Harish" <Harish.Kasiviswanathan@amd.com>,
x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran
Date: Fri, 14 May 2021 13:06:33 +0000 [thread overview]
Message-ID: <DM4PR12MB52634855954DCE456D244288EE509@DM4PR12MB5263.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YJ4hS/SJYmCC9Rpd@zn.tnic>
[AMD Official Use Only - Internal Distribution Only]
> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Friday, May 14, 2021 3:06 AM
> To: Joshi, Mukul <Mukul.Joshi@amd.com>
> Cc: amd-gfx@lists.freedesktop.org; Kasiviswanathan, Harish
> <Harish.Kasiviswanathan@amd.com>; x86-ml <x86@kernel.org>; lkml <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran
>
> [CAUTION: External Email]
>
> On Thu, May 13, 2021 at 11:10:34PM +0000, Joshi, Mukul wrote:
> > That's probably not the best example to look at.
>
> Oh, it is the *perfect* example but...
>
I would prefer not to get into an argument of if it is the perfect example or not.
I would prefer to get the job done and move forward.
> > smca_get_long_name() is used in drivers/edac/mce_amd.c and this file
> > doesn't get compiled when CONFIG_X86_MCE_AMD is not defined.
> >
> > And amdgpu driver has no dependency on CONFIG_X86_MCE_AMD.
>
> ... maybe this will make you see it the right way: how much of the amdgpu RAS
> functionality you're adding, is going to even function without
> CONFIG_X86_MCE_AMD?
>
We have RAS functionality in other ASICs that is not dependent on CONFIG_X86_MCE_AMD.
So, I don't think we would want to do that just for one ASIC.
Maybe Alex D. has an opinion on it.
As I had mentioned in my previous comment, I am fine with wrapping around my code with
#ifdef CONFIG_X86_MCE_AMD and exporting smca_get_bank_type().
I hope we can move forward with this approach.
Thanks,
Mukul
> --
> Regards/Gruss,
> Boris.
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.
> kernel.org%2Ftglx%2Fnotes-about-
> netiquette&data=04%7C01%7CMukul.Joshi%40amd.com%7C7fded9165e6
> 64dde943808d916a6b33f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0
> %7C637565727509040995%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata
> =5hNyAEla4H%2BN0kMdCDs6iL0Dr8mVQJNxKA0UXJU7%2F8c%3D&reserv
> ed=0
next prev parent reply other threads:[~2021-05-14 13:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210512013058.6827-1-mukul.joshi@amd.com>
2021-05-12 9:36 ` [PATCH] drm/amdgpu: Register bad page handler for Aldebaran Borislav Petkov
2021-05-12 19:00 ` Joshi, Mukul
2021-05-12 21:05 ` Borislav Petkov
2021-05-13 3:20 ` Joshi, Mukul
2021-05-13 9:53 ` Borislav Petkov
2021-05-13 14:17 ` Alex Deucher
2021-05-13 14:30 ` Borislav Petkov
2021-05-13 14:32 ` Alex Deucher
2021-05-13 14:57 ` Borislav Petkov
2021-05-13 15:02 ` Alex Deucher
2021-05-13 23:14 ` Joshi, Mukul
2021-05-14 7:03 ` Borislav Petkov
2021-05-27 19:54 ` Joshi, Mukul
2021-06-03 21:13 ` Yazen Ghannam
2021-07-29 23:59 ` Joshi, Mukul
2021-09-13 1:31 ` Joshi, Mukul
2021-05-13 23:10 ` Joshi, Mukul
2021-05-14 7:05 ` Borislav Petkov
2021-05-14 13:06 ` Joshi, Mukul [this message]
2021-05-14 14:38 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB52634855954DCE456D244288EE509@DM4PR12MB5263.namprd12.prod.outlook.com \
--to=mukul.joshi@amd.com \
--cc=Harish.Kasiviswanathan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).