From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
Greg KH <gregkh@linuxfoundation.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"huobean@gmail.com" <huobean@gmail.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>
Cc: "hanjinyi@sk.com" <hanjinyi@sk.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JinHwan Park <jh.i.park@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Dukhyun Kwon <d_hyun.kwon@samsung.com>,
Keoseong Park <keosung.park@samsung.com>,
Jaemyung Lee <jaemyung.lee@samsung.com>,
Jieon Seol <jieon.seol@samsung.com>
Subject: RE: [PATCH v32 4/4] scsi: ufs: Add HPB 2.0 support
Date: Wed, 14 Apr 2021 09:06:11 +0000 [thread overview]
Message-ID: <DM6PR04MB657548321E9521F76BF2436EFC4E9@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20210331011839epcms2p45d3d059fcd9e85a548014a79c3f388bc@epcms2p4>
> From: Daejun Park <daejun7.park@samsung.com>
>
> @@ -1692,6 +2188,7 @@ static void ufshpb_hpb_lu_prepared(struct ufs_hba
> *hba)
> ufshpb_set_state(hpb, HPB_PRESENT);
> if ((hpb->lu_pinned_end - hpb->lu_pinned_start) > 0)
> queue_work(ufshpb_wq, &hpb->map_work);
> + ufshpb_issue_umap_all_req(hpb);
> HPB-WRITE-BUFFER with buffer-id = 0x3h is supported in device control mode
> only
> so I think it is necessary to distinguish device mode and host mode.
You are correct.
Since Daejun's driver's scope is device mode only - see ufshpb_get_dev_info,
This needs to be fixed in the host mode series.
I will fix it in my next version.
Thanks,
Avri
> } else {
> dev_err(hba->dev, "destroy HPB lu %d\n", hpb->lun);
> ufshpb_destroy_lu(hba, sdev);
>
next prev parent reply other threads:[~2021-04-14 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210331011526epcms2p37684869a9781d1eb45bfcbfe9babd217@epcms2p3>
2021-03-31 1:15 ` [PATCH v32 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20210331011526epcms2p37684869a9781d1eb45bfcbfe9babd217@epcms2p4>
2021-03-31 1:16 ` [PATCH v32 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-03-31 1:18 ` [PATCH v32 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-31 3:21 ` Can Guo
2021-04-14 9:06 ` Avri Altman [this message]
2021-04-19 7:19 ` Avri Altman
2021-04-20 14:25 ` Avri Altman
2021-04-21 14:13 ` Avri Altman
2021-03-31 19:40 ` [PATCH v32 0/4] scsi: ufs: Add Host Performance Booster Support Bean Huo
2021-04-06 17:21 ` Javier Gonzalez
2021-04-26 2:36 ` Can Guo
[not found] ` <CGME20210331011526epcms2p37684869a9781d1eb45bfcbfe9babd217@epcms2p7>
2021-04-26 2:48 ` Daejun Park
[not found] ` <CGME20210331011526epcms2p37684869a9781d1eb45bfcbfe9babd217@epcms2p2>
2021-03-31 1:16 ` [PATCH v32 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-03-31 1:17 ` [PATCH v32 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2021-04-28 0:37 ` RE: [PATCH v32 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB657548321E9521F76BF2436EFC4E9@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=d_hyun.kwon@samsung.com \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanjinyi@sk.com \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=jaemyung.lee@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=jieon.seol@samsung.com \
--cc=keosung.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).