From: Vadim Pasternak <vadimp@nvidia.com>
To: Hans de Goede <hdegoede@redhat.com>,
Arnd Bergmann <arnd@kernel.org>,
"Mark Gross" <mgross@linux.intel.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Michael Shych <michaelsh@mellanox.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>
Subject: RE: [PATCH] platform/x86: mlx-platform: remove an unused variable
Date: Mon, 7 Dec 2020 14:02:07 +0000 [thread overview]
Message-ID: <DM6PR12MB3898268DE033A52828D7297DAFCE0@DM6PR12MB3898.namprd12.prod.outlook.com> (raw)
In-Reply-To: <64393b7e-ba81-1545-dfe8-bc3567dd534b@redhat.com>
> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Monday, December 07, 2020 3:54 PM
> To: Arnd Bergmann <arnd@kernel.org>; Vadim Pasternak
> <vadimp@nvidia.com>; Mark Gross <mgross@linux.intel.com>; Nathan
> Chancellor <natechancellor@gmail.com>; Nick Desaulniers
> <ndesaulniers@google.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Michael Shych
> <michaelsh@mellanox.com>; platform-driver-x86@vger.kernel.org; linux-
> kernel@vger.kernel.org; clang-built-linux@googlegroups.com
> Subject: Re: [PATCH] platform/x86: mlx-platform: remove an unused variable
>
> Hi,
>
> On 12/3/20 11:30 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The only reference to the mlxplat_mlxcpld_psu[] array got removed, so
> > there is now a warning from clang:
> >
> > drivers/platform/x86/mlx-platform.c:322:30: error: variable
> > 'mlxplat_mlxcpld_psu' is not needed and will not be emitted
> > [-Werror,-Wunneeded-internal-declaration]
> > static struct i2c_board_info mlxplat_mlxcpld_psu[] = {
> >
> > Remove the array as well and adapt the ARRAY_SIZE() call accordingly.
> >
> > Fixes: 912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM
> > from MSN274x platform configuration")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thank you for your patch.
>
> Note that there are 4 more cases where the foo1 and foo2 in:
> .data = foo1 and .count = ARRAY_SIZE(foo2) are not the same.
>
> There are 2 cases where .count is set to ARRAY_SIZE(mlxplat_mlxcpld_pwr)
> instead of to ARRAY_SIZE(mlxplat_mlxcpld_default_pwr_items_data)
>
> and there are 2 cases where .count is set to ARRAY_SIZE(mlxplat_mlxcpld_fan)
> instead of to ARRAY_SIZE(mlxplat_mlxcpld_default_fan_items_data)
>
> If one of the MLX people can provide a patch fixing this then that would be
> great.
Hi,
I'll provide a patch.
Thanks,
Vadim.
>
> ###
>
> I've applied this patch to my review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-
> x86.git/log/?h=review-hans
>
> Note it will show up in my review-hans branch once I've pushed my local
> branch there, which might take a while.
>
> Once I've run some tests on this branch the patches there will be added to the
> platform-drivers-x86/for-next branch and eventually will be included in the
> pdx86 pull-request to Linus for the next merge-window.
>
> Regards,
>
> Hans
>
>
>
>
>
> > ---
> > drivers/platform/x86/mlx-platform.c | 13 ++-----------
> > 1 file changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/platform/x86/mlx-platform.c
> > b/drivers/platform/x86/mlx-platform.c
> > index 598f44558764..6a634b72bfc2 100644
> > --- a/drivers/platform/x86/mlx-platform.c
> > +++ b/drivers/platform/x86/mlx-platform.c
> > @@ -319,15 +319,6 @@ static struct i2c_mux_reg_platform_data
> > mlxplat_extended_mux_data[] = { };
> >
> > /* Platform hotplug devices */
> > -static struct i2c_board_info mlxplat_mlxcpld_psu[] = {
> > - {
> > - I2C_BOARD_INFO("24c02", 0x51),
> > - },
> > - {
> > - I2C_BOARD_INFO("24c02", 0x50),
> > - },
> > -};
> > -
> > static struct i2c_board_info mlxplat_mlxcpld_pwr[] = {
> > {
> > I2C_BOARD_INFO("dps460", 0x59),
> > @@ -456,7 +447,7 @@ static struct mlxreg_core_item
> mlxplat_mlxcpld_default_items[] = {
> > .aggr_mask = MLXPLAT_CPLD_AGGR_PSU_MASK_DEF,
> > .reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET,
> > .mask = MLXPLAT_CPLD_PSU_MASK,
> > - .count = ARRAY_SIZE(mlxplat_mlxcpld_psu),
> > + .count =
> ARRAY_SIZE(mlxplat_mlxcpld_default_psu_items_data),
> > .inversed = 1,
> > .health = false,
> > },
> > @@ -495,7 +486,7 @@ static struct mlxreg_core_item
> mlxplat_mlxcpld_comex_items[] = {
> > .aggr_mask = MLXPLAT_CPLD_AGGR_MASK_CARRIER,
> > .reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET,
> > .mask = MLXPLAT_CPLD_PSU_MASK,
> > - .count = ARRAY_SIZE(mlxplat_mlxcpld_psu),
> > + .count =
> ARRAY_SIZE(mlxplat_mlxcpld_default_psu_items_data),
> > .inversed = 1,
> > .health = false,
> > },
> >
prev parent reply other threads:[~2020-12-07 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 22:30 [PATCH] platform/x86: mlx-platform: remove an unused variable Arnd Bergmann
2020-12-03 23:17 ` Vadim Pasternak
2020-12-07 13:53 ` Hans de Goede
2020-12-07 14:02 ` Vadim Pasternak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3898268DE033A52828D7297DAFCE0@DM6PR12MB3898.namprd12.prod.outlook.com \
--to=vadimp@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=michaelsh@mellanox.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).