From: Daniel Phillips <phillips@arcor.de>
To: davidm@hpl.hp.com, David Mosberger <davidm@napali.hpl.hp.com>,
Dave Olien <dmo@osdl.org>
Cc: axboe@suse.de, _deepfire@mail.ru, linux-kernel@vger.kernel.org
Subject: Re: DAC960 in 2.5.38, with new changes
Date: Mon, 23 Sep 2002 22:44:08 +0200 [thread overview]
Message-ID: <E17ta3t-0003bj-00@starship> (raw)
In-Reply-To: <15759.26918.381273.951266@napali.hpl.hp.com>
On Monday 23 September 2002 21:19, David Mosberger wrote:
> Hi Dave,
>
> >>>>> On Mon, 23 Sep 2002 12:04:00 -0700, Dave Olien <dmo@osdl.org> said:
>
> Dave> #ifdef __ia64__
> Dave> - writeq(Virtual_to_Bus64(CommandMailbox),
> Dave> + writeq(CommandMailboxDMA,
> Dave> ControllerBaseAddress + DAC960_LP_CommandMailboxBusAddressOffset);
> Dave> #else
> Dave> - writel(Virtual_to_Bus32(CommandMailbox),
> Dave> + writel(CommandMailboxDMA,
> Dave> ControllerBaseAddress + DAC960_LP_CommandMailboxBusAddressOffset);
> Dave> #endif
>
> This looks like a porting-nightmare in the making. There's got to be a
> better way to determine whether you need a writeq() vs. a writel().
Even if an #ifdef is necessary here (and we are in trouble if it is) it
should not trigger on __ia64__, it should trigger on the size of (long).
--
Daniel
next prev parent reply other threads:[~2002-09-23 20:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-23 19:04 DAC960 in 2.5.38, with new changes Dave Olien
2002-09-23 19:19 ` David Mosberger
2002-09-23 20:40 ` David S. Miller
2002-09-23 20:53 ` David Mosberger
2002-09-23 20:57 ` David S. Miller
2002-09-23 21:24 ` David Mosberger
2002-09-23 21:17 ` David S. Miller
2002-09-23 21:32 ` David Mosberger
2002-09-23 21:28 ` David S. Miller
2002-09-23 21:31 ` Daniel Phillips
2002-09-23 21:33 ` David Mosberger
2002-09-23 21:28 ` David S. Miller
2002-09-23 21:40 ` Daniel Phillips
2002-09-23 21:45 ` David Mosberger
2002-09-23 20:44 ` Daniel Phillips [this message]
2002-09-23 20:54 ` David S. Miller
2002-09-24 16:54 ` Dave Olien
2002-09-24 17:11 ` David Mosberger
2002-09-24 17:28 ` Dave Olien
2002-09-24 18:21 ` David Mosberger
2002-09-24 18:25 ` Dave Olien
2002-09-24 19:12 ` David Mosberger
2002-09-24 18:45 ` Dave Olien
2002-09-24 17:50 ` Daniel Phillips
2002-09-24 18:27 ` David Mosberger
2002-09-24 17:39 ` Daniel Phillips
2002-09-25 22:20 ` DAC960, documentation links Daniel Phillips
2002-09-25 22:23 ` Daniel Phillips
2002-09-26 0:02 ` Mr. James W. Laferriere
2002-09-26 16:13 ` DAC960 in 2.5.38, with new changes Alan Cox
2002-09-24 17:45 ` Daniel Phillips
2002-09-25 21:42 ` davide.rossetti
2002-09-23 20:39 ` Daniel Phillips
2002-09-23 21:41 ` Dave Olien
2002-09-23 21:53 ` Daniel Phillips
2002-09-23 22:03 ` Dave Olien
2002-09-23 22:22 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17ta3t-0003bj-00@starship \
--to=phillips@arcor.de \
--cc=_deepfire@mail.ru \
--cc=axboe@suse.de \
--cc=davidm@hpl.hp.com \
--cc=davidm@napali.hpl.hp.com \
--cc=dmo@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).