linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: "kan.liang@linux.intel.com" <kan.liang@linux.intel.com>
Subject: perf/x86/intel/uncore
Date: Fri, 25 Jan 2019 18:54:24 +0000	[thread overview]
Message-ID: <E44A3BE5-E45A-4D88-818C-02E6E6342060@fb.com> (raw)

Hi,

We are debugging an issue that skx_pci_uncores cannot be registered on
8-socket system with Xeon Platinum 8176 CPUs. After poking around for a
while, I found it is caused by snbep_pci2phy_map_init() couldn't find
a unbox_dev:

  ubox_dev = pci_get_device(PCI_VENDOR_ID_INTEL, devid, ubox_dev);
  unbox_dev == NULL
  ...

The same kernel (Linus' master) works fine on some single socket SKX
systems.

I am not sure what to check next. And I am not sure whether this is
specific to this system (HPE Superdome Flex).

One thing I noticed is that the PCI configuration space shows
subsystem vendor ID of 0x1590 instead of 0x8086:

0000:00:08.0 System peripheral: Intel Corporation Sky Lake-E Ubox Registers (rev 04)
00: 86 80 14 20 00 00 10 00 04 00 80 08 00 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 90 15 14 20   << subsystem vendor

30: 00 00 00 00 40 00 00 00 00 00 00 00 00 00 00 00

But I don't think that is the problem as the code search with PCI_ANY_ID.


Any suggestions on what might be broken? And what to try next?

Thanks in advance!
Song

             reply	other threads:[~2019-01-25 18:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 18:54 Song Liu [this message]
2019-01-25 20:08 ` perf/x86/intel/uncore Liang, Kan
2019-01-25 20:16   ` perf/x86/intel/uncore Song Liu
2019-01-25 21:35     ` perf/x86/intel/uncore Liang, Kan
2019-01-25 22:24       ` perf/x86/intel/uncore Song Liu
2019-01-25 22:42         ` perf/x86/intel/uncore Liang, Kan
2019-01-25 22:45           ` perf/x86/intel/uncore Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E44A3BE5-E45A-4D88-818C-02E6E6342060@fb.com \
    --to=songliubraving@fb.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).