From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424266AbcFMOaN (ORCPT ); Mon, 13 Jun 2016 10:30:13 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:2415 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422860AbcFMOaI (ORCPT ); Mon, 13 Jun 2016 10:30:08 -0400 From: Gabriele Paoloni To: Sinan Kaya , "liudongdong (C)" , "helgaas@kernel.org" , "arnd@arndb.de" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "rafael@kernel.org" , "hanjun.guo@linaro.org" , "Lorenzo.Pieralisi@arm.com" , "jchandra@broadcom.com" , "tn@semihalf.com" CC: "robert.richter@caviumnetworks.com" , "mw@semihalf.com" , "Liviu.Dudau@arm.com" , "ddaney@caviumnetworks.com" , Wangyijing , "Suravee.Suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "jcm@redhat.com" , "andrea.gallo@linaro.org" , "dhdang@apm.com" , "jeremy.linton@arm.com" , "cov@codeaurora.org" , "Chenxin (Charles)" , Linuxarm Subject: RE: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Thread-Topic: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks Thread-Index: AQHRxXIkbhAnIs/vBUuIDrYXXwhW9p/naITg///0aYCAABazAA== Date: Mon, 13 Jun 2016 14:29:01 +0000 Message-ID: References: <1465822923-33599-1-git-send-email-liudongdong3@huawei.com> <1465822923-33599-2-git-send-email-liudongdong3@huawei.com> <575EBD13.8080808@codeaurora.org> In-Reply-To: <575EBD13.8080808@codeaurora.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.210.142.221] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.575EC33B.0242,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: bb0af71c6e23a3edab589804df4cfb29 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5DEUIok008512 Hi Sinan > -----Original Message----- > From: Sinan Kaya [mailto:okaya@codeaurora.org] > Sent: 13 June 2016 15:03 > To: Gabriele Paoloni; liudongdong (C); helgaas@kernel.org; > arnd@arndb.de; will.deacon@arm.com; catalin.marinas@arm.com; > rafael@kernel.org; hanjun.guo@linaro.org; Lorenzo.Pieralisi@arm.com; > jchandra@broadcom.com; tn@semihalf.com > Cc: robert.richter@caviumnetworks.com; mw@semihalf.com; > Liviu.Dudau@arm.com; ddaney@caviumnetworks.com; Wangyijing; > Suravee.Suthikulpanit@amd.com; msalter@redhat.com; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro- > acpi@lists.linaro.org; jcm@redhat.com; andrea.gallo@linaro.org; > dhdang@apm.com; jeremy.linton@arm.com; cov@codeaurora.org; Chenxin > (Charles); Linuxarm > Subject: Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space > accessors against platfrom specific ECAM quirks > > On 6/13/2016 9:54 AM, Gabriele Paoloni wrote: > > As you can see here Liudongdong has replaced oem_revision with > > oem_table_id. > > > > Now it seems that there are some platforms that have already shipped > > using a matching based on the oem_revision (right Jon?) > > > > However I guess that if in FW they have defined oem_table_id properly > > they should be able to use this mechanism without needing to a FW > update. > > > > Can these vendors confirm this? > > > > Tomasz do you think this can work for Cavium Thunder? > > > > Thanks > > > > Gab > > Why not have all three of them? > > The initial approach was OEM id and revision id. > > Jeff Hugo indicated that addition (not removing any other fields) of > table id > would make more sense. Mmm from last email of Jeff Hugo on "[RFC PATCH 1/3] pci, acpi: Match PCI config space accessors against platfrom specific ECAM quirks." I quote: "Using the OEM revision field does not seem to be appropriate since these are different platforms and the revision field appears to be for the purpose of tracking differences within a single platform. Therefore, Cov is proposing using the OEM table id as a mechanism to distinguish platform A (needs quirk applied) vs platform B (no quirks) from the same OEM." So it looks to me that he pointed out that using the OEM revision field is wrong...and this is why I have asked if replacing it with the table id can work for other vendors.... Thanks Gab > > -- > Sinan Kaya > Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, > Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a > Linux Foundation Collaborative Project