From: Andy Lutomirski <luto@amacapital.net>
To: "Bae, Chang Seok" <chang.seok.bae@intel.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
Andi Kleen <ak@linux.intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [RESEND PATCH v6 08/12] x86/fsgsbase/64: Use the per-CPU base as GSBASE at the paranoid_entry
Date: Wed, 1 May 2019 17:29:55 -0700 [thread overview]
Message-ID: <F1D424D8-B210-47E3-9E56-FFFF0305BF86@amacapital.net> (raw)
In-Reply-To: <2B69DB9F-A3FC-4C60-BA51-E11EB9C5877D@intel.com>
> On May 1, 2019, at 2:04 PM, Bae, Chang Seok <chang.seok.bae@intel.com> wrote:
>
>
>> On May 1, 2019, at 13:25, Andy Lutomirski <luto@amacapital.net> wrote:
>>
>>
>>
>>> On May 1, 2019, at 1:21 PM, Bae, Chang Seok <chang.seok.bae@intel.com> wrote:
>>>
>>>
>>>>> On May 1, 2019, at 11:01, Bae, Chang Seok <chang.seok.bae@intel.com> wrote:
>>>>>
>>>>> On May 1, 2019, at 10:40, Andy Lutomirski <luto@kernel.org> wrote:
>>>>>
>>>>>> On Wed, May 1, 2019 at 6:52 AM Bae, Chang Seok <chang.seok.bae@intel.com> wrote:
>>>>>>
>>>>>>
>>>>>>> On Apr 5, 2019, at 06:50, Andy Lutomirski <luto@amacapital.net> wrote:
>>>>>>>
>>>>>>> Furthermore, if you folks even want me to review this series, the ptrace tests need to be in place. On inspection of the current code (after the debacle a few releases back), it appears the SETREGSET’s effect depends on the current values in the registers — it does not actually seem to reliably load the whole state. So my confidence will be greatly increased if your series first adds a test that detects that bug (and fails!), then fixes the bug in a tiny little patch, then adds FSGSBASE, and keeps the test working.
>>>>>>>
>>>>>>
>>>>>> I think I need to understand the issue. Appreciate if you can elaborate a little bit.
>>>>>>
>>>>>
>>>>> This patch series gives a particular behavior to PTRACE_SETREGS and
>>>>> PTRACE_POKEUSER. There should be a test case that validates that
>>>>> behavior, including testing the weird cases where gs != 0 and gsbase
>>>>> contains unusual values. Some existing tests might be pretty close to
>>>>> doing what's needed.
>>>>>
>>>>> Beyond that, the current putreg() code does this:
>>>>>
>>>>> case offsetof(struct user_regs_struct,gs_base):
>>>>> /*
>>>>> * Exactly the same here as the %fs handling above.
>>>>> */
>>>>> if (value >= TASK_SIZE_MAX)
>>>>> return -EIO;
>>>>> if (child->thread.gsbase != value)
>>>>> return do_arch_prctl_64(child, ARCH_SET_GS, value);
>>>>> return 0;
>>>>>
>>>>> and do_arch_prctl_64(), in turn, does this:
>>>>>
>>>>> case ARCH_SET_GS: {
>>>>> if (unlikely(arg2 >= TASK_SIZE_MAX))
>>>>> return -EPERM;
>>>>>
>>>>> preempt_disable();
>>>>> /*
>>>>> * ARCH_SET_GS has always overwritten the index
>>>>> * and the base. Zero is the most sensible value
>>>>> * to put in the index, and is the only value that
>>>>> * makes any sense if FSGSBASE is unavailable.
>>>>> */
>>>>> if (task == current) {
>>>>> [not used for ptrace]
>>>>> } else {
>>>>> task->thread.gsindex = 0;
>>>>> x86_gsbase_write_task(task, arg2);
>>>>> }
>>>>>
>>>>> ...
>>>>>
>>>>> So writing the value that was already there to gsbase via putreg()
>>>>> does nothing, but writing a *different* value implicitly clears gs,
>>>>> but writing a different value will clear gs.
>>>>>
>>>>> This behavior is, AFAICT, complete nonsense. It happens to work
>>>>> because usually gdb writes the same value back, and, in any case, gs
>>>>> comes *after* gsbase in user_regs_struct, so gs gets replaced anyway.
>>>>> But I think that this behavior should be fixed up and probably tested.
>>>>> Certainly the behavior should *not* be the same on a fsgsbase kernel,
>>>>> and and the fsgsbase behavior definitely needs a selftest.
>>>>
>>>> Okay, got the point; now crystal clear.
>>>>
>>>> I have my own test case for that though, need to find a very simple and
>>>> acceptable solution.
>>>>
>>>
>>> One solution that I recall, HPA once suggested, is:
>>> Write registers in a reverse order from user_regs_struct, for SETREGS
>>>
>>> Assuming these for clarification, first:
>>> * old and new index != 0
>>> * taking GS as an example though, should be the same with FS
>>>
>>> Then, interesting cases would be something like these, without FSGSBASE:
>>> Case (a), when index only changed to (new index):
>>> (Then, the result after SETREGS would be)
>>> GS = (new index), GSBASE = the base fetched from (new index)
>>> Case (b), when base only changed to (new base):
>>> Case (c), when both are changed:
>>> GS = 0, GSBASE = (new base)
>>>
>>> Now, with FSGSBASE:
>>> Case (a):
>>> GS = (new index), GSBASE = (old base)
>>> Case (b):
>>> GS = (old index), GSBASE = (new base)
>>> Case (c):
>>> GS = (new index), GSBASE = (new base)
>>>
>>> As a reference, today's kernel behavior, without FSGSBASE:
>>> Case (a):
>>> GS = (new index), GSBASE = the base fetched from (new index)
>>> Case (b):
>>> GS = (old index), GSBASE = (old base)
>>> Case (c):
>>> GS = (new index), GSBASE = the base fetched from (new index)
>>>
>>> Now, with that reverse ordering and taking that "GSBASE is important" [1],
>>> it looks like to be working in terms of its base value:
>>> Case (b) and (c) will behave the same as with FSGSBASE
>>> Case (a) still differs between w/ and w/o FSGSBASE.
>>> Well, I'd say this bit comes from the 'new model' vs. the 'leagcy
>>> model'. So, then okay with that. Any thoughts?
>>>
>>>
>>>
>>
>> This seems more complicated than needed. How about we just remove all the magic and make putreg on the base registers never change the selector.
>>
>
> Hmm, just wonder what's benefit in terms of making a non-FSGSBASE system
> behave more similar to one with FSGSBASE (although I would buy that removal).
Simplicity. The current behavior is IMO nuts.
> Well, if we're okay with such divergence, maybe that's it.
>
>> As far as I can tell, the only downside is that, on a non-FSGSBASE kernel, setting only the base if the selector already has a nonzero value won’t work, but I would be quite surprised if this breaks anything.
>
>
>
next prev parent reply other threads:[~2019-05-02 0:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 20:06 [RESEND PATCH v6 00/12] x86: Enable FSGSBASE instructions Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 01/12] x86/fsgsbase/64: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASE Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 02/12] kbuild: Raise the minimum required binutils version to 2.21 Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 03/12] x86/fsgsbase/64: Add intrinsics for FSGSBASE instructions Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 04/12] x86/fsgsbase/64: Enable FSGSBASE instructions in the helper functions Chang S. Bae
2019-03-25 11:38 ` Thomas Gleixner
2019-03-25 12:46 ` Thomas Gleixner
2019-03-25 13:05 ` Thomas Gleixner
2019-03-26 0:38 ` Andi Kleen
2019-03-26 15:01 ` New feature/ABI review process [was Re: [RESEND PATCH v6 04/12] x86/fsgsbase/64:..] Thomas Gleixner
2019-03-26 22:56 ` Andi Kleen
2019-03-27 21:15 ` Thomas Gleixner
2019-03-15 20:06 ` [RESEND PATCH v6 05/12] x86/fsgsbase/64: Preserve FS/GS state in __switch_to() if FSGSBASE is on Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 06/12] x86/fsgsbase/64: When copying a thread, use the FSGSBASE instructions if available Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 07/12] x86/fsgsbase/64: Introduce the FIND_PERCPU_BASE macro Chang S. Bae
2019-03-25 9:02 ` Thomas Gleixner
2019-05-01 13:52 ` Bae, Chang Seok
2019-03-15 20:06 ` [RESEND PATCH v6 08/12] x86/fsgsbase/64: Use the per-CPU base as GSBASE at the paranoid_entry Chang S. Bae
2019-03-25 9:44 ` Thomas Gleixner
2019-04-05 8:35 ` Thomas Gleixner
2019-04-05 13:50 ` Andy Lutomirski
2019-05-01 13:52 ` Bae, Chang Seok
2019-05-01 17:40 ` Andy Lutomirski
2019-05-01 18:01 ` Bae, Chang Seok
[not found] ` <7029A32B-958E-4C1E-8B5F-D49BA68E4755@intel.com>
2019-05-01 20:25 ` Andy Lutomirski
2019-05-01 21:04 ` Bae, Chang Seok
2019-05-02 0:29 ` Andy Lutomirski [this message]
2019-05-06 22:56 ` Bae, Chang Seok
2019-03-15 20:06 ` [RESEND PATCH v6 09/12] selftests/x86/fsgsbase: Test WRGSBASE Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 10/12] x86/fsgsbase/64: Enable FSGSBASE by default and add a chicken bit Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 11/12] x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2 Chang S. Bae
2019-03-15 20:06 ` [RESEND PATCH v6 12/12] x86/fsgsbase/64: Add documentation for FSGSBASE Chang S. Bae
2019-03-30 16:15 ` Randy Dunlap
2019-03-26 0:43 ` [RESEND PATCH v6 00/12] x86: Enable FSGSBASE instructions Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F1D424D8-B210-47E3-9E56-FFFF0305BF86@amacapital.net \
--to=luto@amacapital.net \
--cc=ak@linux.intel.com \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).