From: "Grover, Andrew" <andrew.grover@intel.com>
To: Andrew Morton <akpm@digeo.com>, Nicolas <linux@1g6.biz>
Cc: linux-kernel@vger.kernel.org
Subject: RE: oops 2.5.68 ohci1394/ IRQ/acpi
Date: Tue, 6 May 2003 11:13:18 -0700 [thread overview]
Message-ID: <F760B14C9561B941B89469F59BA3A84725A28E@orsmsx401.jf.intel.com> (raw)
Ohhh so we need to not just return nonzero, but return 1 (aka
IRQ_HANDLED?) Well, then this makes sense. Sorry about that.
btw I think the line in handle_IRQ_event that reads
if (retval != 1) {
should be
if (retval != IRQ_HANDLED) {
but that's just a nit.
Regards -- Andy
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@digeo.com]
> Sent: Monday, May 05, 2003 2:16 PM
> To: Nicolas
> Cc: linux-kernel@vger.kernel.org; Grover, Andrew
> Subject: Re: oops 2.5.68 ohci1394/ IRQ/acpi
> Importance: High
>
>
> Nicolas <linux@1g6.biz> wrote:
> >
> >
> > May 5 13:36:56 hal9003 kernel: irq 9: nobody cared!
> > ...
> > May 5 13:36:56 hal9003 kernel: handlers:
> > May 5 13:36:56 hal9003 kernel: [acpi_irq+0/17] (acpi_irq+0x0/0x11)
> > May 5 13:36:56 hal9003 kernel: [<c01c1ff0>] (acpi_irq+0x0/0x11)
>
> Look like the ACPI IRQ handler isn't returning an appropriate value.
>
> Can you test this patch?
>
> diff -puN drivers/acpi/osl.c~acpi-irq-ret-fix drivers/acpi/osl.c
> --- 25/drivers/acpi/osl.c~acpi-irq-ret-fix Mon May 5 14:14:24 2003
> +++ 25-akpm/drivers/acpi/osl.c Mon May 5 14:14:38 2003
> @@ -237,7 +237,7 @@ acpi_os_table_override (struct acpi_tabl
> static irqreturn_t acpi_irq(int irq, void *dev_id, struct
> pt_regs *regs) {
> - return (*acpi_irq_handler)(acpi_irq_context);
> + return (*acpi_irq_handler)(acpi_irq_context) ?
> IRQ_HANDLED : IRQ_NONE;
> }
>
> acpi_status
>
> _
>
next reply other threads:[~2003-05-06 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 18:13 Grover, Andrew [this message]
2003-05-06 18:36 ` oops 2.5.68 ohci1394/ IRQ/acpi Jeff Garzik
2003-05-06 20:42 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2003-05-05 11:50 Nicolas
2003-05-05 21:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F760B14C9561B941B89469F59BA3A84725A28E@orsmsx401.jf.intel.com \
--to=andrew.grover@intel.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@1g6.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).