From: Rahul Tanwar <rtanwar@maxlinear.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arnd Bergmann <arnd@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Adam Borowski <kilobyte@angband.pl>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
John Crispin <john@phrozen.org>,
Hauke Mehrtens <hmehrtens@maxlinear.com>,
Cheol Yong Kim <ckim@maxlinear.com>,
Qiming Wu <qwu@maxlinear.com>
Subject: Re: [PATCH 1/1] leds: lgm: Improve Kconfig help
Date: Thu, 18 Mar 2021 09:49:22 +0000 [thread overview]
Message-ID: <MN2PR19MB3693318349FCCF3201E8EA80B1699@MN2PR19MB3693.namprd19.prod.outlook.com> (raw)
In-Reply-To: 20210318075552.GA2331@amd
Hi Pavel,
On 18/3/2021 3:55 pm, Pavel Machek wrote:
> Hi!
>
> > Remove unnecessary Kconfig symbol LEDS_BLINK
> > Improve Kconfig help text to make it more useful.
> >
> > Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
>
> > +++ b/drivers/leds/blink/Kconfig
> > @@ -1,21 +1,19 @@
> > -menuconfig LEDS_BLINK
> > - bool "LED Blink support"
> > - depends on LEDS_CLASS
> > - help
> > - This option enables blink support for the leds class.
> > - If unsure, say Y.
> > -
> > -if LEDS_BLINK
> > -
> > -config LEDS_BLINK_LGM
> > - tristate "LED support for Intel LGM SoC series"
> > +config LEDS_LGM
> > + tristate "LED support for LGM SoC series"
> > depends on GPIOLIB
> > depends on LEDS_CLASS
> > depends on MFD_SYSCON
> > depends on OF
> > help
> > - Parallel to serial conversion, which is also called SSO
> > controller,
> > - can drive external shift register for LED outputs.
> > - This enables LED support for Serial Shift Output controller(SSO).
> > + This option enables support for LEDs connected to GPIO lines on
> > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
> > + Shift Output(SSO) controller. The driver supports hardware
>
> What is Lightning Mountain? The codename is not widely known. Where
> can we find that hardware? Notebooks? Phones? Only some development
> boards?
>
Lightning Mountain is generically a network processor with a primary
targeted application as Gateway SoC. It has already been added as a
valid Intel Atom processor variant in
arch/x86/include/asm/intel-family.h as below:
#define INTEL_FAM6_ATOM_AIRMONT_NP 0x75 /* Lightning Mountain */
Please see [1].
> If user is not likely to need the driver, say so.
>
> > + blinking with a configurable LED update/blink frequency in two
> > + modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250
> > KHz in
>
> kHz? But I guess we don't need that here.
>
Well noted. Will update in V2.
> > *
> > - * Copyright (c) 2020 Intel Corporation.
> > + * Copyright (c) 2021 MaxLinear, Inc.
> > */
> >
>
> I don't think you can do that, and I don't think you should be doing
> it in the same patch.
Well noted. Will revert it back now and update later in a separate
patch. Thanks.
>
Regards,
Rahul
[1]
https://github.com/torvalds/linux/blob/master/arch/x86/include/asm/intel-family.h
next prev parent reply other threads:[~2021-03-18 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8ae0456a08ef1a2491fd382b273ff7259e6fcbd0.1615969806.git.rtanwar@maxlinear.com>
2021-03-17 10:04 ` [PATCH 1/1] leds: lgm: Improve Kconfig help Rahul Tanwar
2021-03-18 1:54 ` Randy Dunlap
2021-03-18 9:24 ` Rahul Tanwar
2021-03-18 9:44 ` Arnd Bergmann
2021-03-18 7:55 ` Pavel Machek
2021-03-18 9:49 ` Rahul Tanwar [this message]
2021-03-18 20:37 ` Pavel Machek
2021-03-19 5:52 ` Rahul Tanwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR19MB3693318349FCCF3201E8EA80B1699@MN2PR19MB3693.namprd19.prod.outlook.com \
--to=rtanwar@maxlinear.com \
--cc=arnd@kernel.org \
--cc=ckim@maxlinear.com \
--cc=hmehrtens@maxlinear.com \
--cc=john@phrozen.org \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=qwu@maxlinear.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).