From: "Kaneda, Erik" <erik.kaneda@intel.com>
To: Wei Ming Chen <jj251510319013@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: RE: [PATCH] ACPICA: Use fallthrough pseudo-keyword
Date: Tue, 11 May 2021 18:20:16 +0000 [thread overview]
Message-ID: <MWHPR11MB1599BD99469D7F2157A4C27FF0539@MWHPR11MB1599.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210506124912.7725-1-jj251510319013@gmail.com>
> -----Original Message-----
> From: Wei Ming Chen <jj251510319013@gmail.com>
> Sent: Thursday, May 6, 2021 5:49 AM
> To: linux-kernel@vger.kernel.org
> Cc: linux-acpi@vger.kernel.org; devel@acpica.org; Wei Ming Chen
> <jj251510319013@gmail.com>
> Subject: [PATCH] ACPICA: Use fallthrough pseudo-keyword
>
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro
> fallthrough[1]
>
> [1]
> https://www.kernel.org/doc/html/latest/process/deprecated.html?highligh
> t=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char
> *format, va_list args)
> case 'X':
>
Hi,
> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + fallthrough;
Since fallthrough is specific to gcc, we use the macro ACPI_FALLTHROUGH for code in drivers/acpi/acpica. Please resubmit using this keyword and I can take the commit for upstream ACPICA.
Thanks,
Erik
>
> case 'x':
>
> --
> 2.25.1
prev parent reply other threads:[~2021-05-11 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 12:49 [PATCH] ACPICA: Use fallthrough pseudo-keyword Wei Ming Chen
2021-05-10 17:06 ` Rafael J. Wysocki
2021-05-11 18:20 ` Kaneda, Erik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1599BD99469D7F2157A4C27FF0539@MWHPR11MB1599.namprd11.prod.outlook.com \
--to=erik.kaneda@intel.com \
--cc=devel@acpica.org \
--cc=jj251510319013@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).