RE: [PATCH v2 29/34] Intel tsens i2c slave driver.

From: "Gross, Mark" <mark.gross@intel.com>
To: Arnd Bergmann <arnd@kernel.org>,
	"mgross@linux.intel.com" <mgross@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	"markgross@kernel.org" <markgross@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@suse.de>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	gregkh <gregkh@linuxfoundation.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"Palmer Dabbelt" <palmerdabbelt@google.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Peng Fan <peng.fan@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"C, Udhayakumar" <udhayakumar.c@intel.com>,
	"C@linux.intel.com" <C@linux.intel.com>
Subject: RE: [PATCH v2 29/34] Intel tsens i2c slave driver.
Date: Tue, 26 Jan 2021 14:56:41 +0000	[thread overview]
Message-ID: <MWHPR11MB1679E3F08F2AFC45FFF549C88EBC9@MWHPR11MB1679.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a0V5wFYypYDXbVFQvzbjL5K0Gp0j+Zfg_7-5vML1B1-Cg@mail.gmail.com>


> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Monday, January 25, 2021 11:45 PM
> To: mgross@linux.intel.com
> Cc: Randy Dunlap <rdunlap@infradead.org>; markgross@kernel.org; Arnd
> Bergmann <arnd@arndb.de>; Borislav Petkov <bp@suse.de>; Damien Le Moal
> <damien.lemoal@wdc.com>; Dragan Cvetic <dragan.cvetic@xilinx.com>; gregkh
> <gregkh@linuxfoundation.org>; Jonathan Corbet <corbet@lwn.net>; Leonard
> Crestez <leonard.crestez@nxp.com>; Palmer Dabbelt
> <palmerdabbelt@google.com>; Paul Walmsley <paul.walmsley@sifive.com>;
> Peng Fan <peng.fan@nxp.com>; Rob Herring <robh+dt@kernel.org>; Shawn
> Guo <shawnguo@kernel.org>; Jassi Brar <jassisinghbrar@gmail.com>; linux-
> kernel@vger.kernel.org; C, Udhayakumar <udhayakumar.c@intel.com>;
> C@linux.intel.com
> Subject: Re: [PATCH v2 29/34] Intel tsens i2c slave driver.
> 
> On Tue, Jan 26, 2021 at 12:39 AM mark gross <mgross@linux.intel.com> wrote:
> >
> > On Mon, Jan 11, 2021 at 11:15:06PM -0800, Randy Dunlap wrote:
> > > On 1/8/21 1:25 PM, mgross@linux.intel.com wrote:
> > > > diff --git a/drivers/misc/intel_tsens/Kconfig
> > > > b/drivers/misc/intel_tsens/Kconfig
> > > > index 8b263fdd80c3..c2138339bd89 100644
> > > > --- a/drivers/misc/intel_tsens/Kconfig
> > > > +++ b/drivers/misc/intel_tsens/Kconfig
> > > > @@ -14,6 +14,20 @@ config INTEL_TSENS_LOCAL_HOST
> > > >       Say Y if using a processor that includes the Intel VPU such as
> > > >       Keem Bay.  If unsure, say N.
> > > >
> > > > +config INTEL_TSENS_I2C_SLAVE
> > > > +   bool "I2C slave driver for intel tsens"
> > >
> > > Why bool instead of tristate?
> > Becuase the I2C driver depends on a file scoped global i2c_plat_data
> > instanciated in the INTELL_TSENS_LOCAL_HOST DRIVER
> > (intel_tsens_thermal.[ch])
> >
> > Udhaya, would you care to comment further?
> 
> > > > +   depends on INTEL_TSENS_LOCAL_HOST
> > > > +   select I2C
> > > > +   select I2C_SLAVE
> 
> Please make this 'depends on I2C=y && I2C_SLAVE' instead of 'select'
> in this case. A random driver should never force-enable another subsystem.
Will do, thanks for the feedback!

--mark