From: "Sa, Nuno" <Nuno.Sa@analog.com>
To: "Antti Keränen" <detegr@rbx.email>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: Hannu Hartikainen <hannu@hrtk.in>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] iio: adis: set GPIO reset pin direction
Date: Thu, 8 Jul 2021 10:05:40 +0000 [thread overview]
Message-ID: <PH0PR03MB6366DFDA5446CDC0D57AB3A199199@PH0PR03MB6366.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20210708095425.13295-1-detegr@rbx.email>
> -----Original Message-----
> From: Antti Keränen <detegr@rbx.email>
> Sent: Thursday, July 8, 2021 11:54 AM
> To: linux-iio@vger.kernel.org
> Cc: Antti Keränen <detegr@rbx.email>; Hannu Hartikainen
> <hannu@hrtk.in>; Lars-Peter Clausen <lars@metafoo.de>; Hennerich,
> Michael <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> open list <linux-kernel@vger.kernel.org>
> Subject: [PATCH v2] iio: adis: set GPIO reset pin direction
>
> Set reset pin direction to output as the reset pin needs to be an active
> low output pin.
>
> Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Antti Keränen <detegr@rbx.email>
> ---
> Removed unnecessary toggling of the pin as requested by Lars-Peter. I
> missed out on the conversation, but I agree this is better.
>
> drivers/iio/imu/adis.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 319b64b2fd88..f8b7837d8b8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
> int ret;
>
> /* check if the device has rst pin low */
> - gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset",
> GPIOD_ASIS);
> + gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset",
> GPIOD_OUT_HIGH);
> if (IS_ERR(gpio))
> return PTR_ERR(gpio);
>
> if (gpio) {
> - gpiod_set_value_cansleep(gpio, 1);
> msleep(10);
> /* bring device out of reset */
> gpiod_set_value_cansleep(gpio, 0);
> --
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Thanks!
- Nuno Sá
next prev parent reply other threads:[~2021-07-08 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <60e5ac8c.1c69fb81.c69f0.abab@mx.google.com>
2021-07-08 9:54 ` [PATCH v2] iio: adis: set GPIO reset pin direction Antti Keränen
2021-07-08 10:05 ` Sa, Nuno [this message]
2021-07-10 17:35 ` Jonathan Cameron
2021-07-13 17:53 ` Jonathan Cameron
2021-07-14 10:04 ` Antti Keränen
2021-07-14 12:40 ` Jonathan Cameron
2021-07-14 18:25 ` Antti Keränen
2021-07-17 17:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR03MB6366DFDA5446CDC0D57AB3A199199@PH0PR03MB6366.namprd03.prod.outlook.com \
--to=nuno.sa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=detegr@rbx.email \
--cc=hannu@hrtk.in \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).