linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
To: Yang Shen <shenyang39@huawei.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ariel Elior <aelior@marvell.com>,
	GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>
Subject: RE: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function name in comments
Date: Wed, 19 May 2021 09:30:48 +0000	[thread overview]
Message-ID: <PH0PR18MB403932EAA58A847383EA6E54D32B9@PH0PR18MB4039.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210517044535.21473-6-shenyang39@huawei.com>

> -----Original Message-----
> From: Yang Shen <shenyang39@huawei.com>
> Sent: Monday, May 17, 2021 10:15 AM
> To: davem@davemloft.net; kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yang Shen
> <shenyang39@huawei.com>; Ariel Elior <aelior@marvell.com>; Sudarsana
> Reddy Kalluru <skalluru@marvell.com>; GR-everest-linux-l2 <GR-everest-
> linux-l2@marvell.com>
> Subject: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function
> name in comments
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13595: warning:
> expecting prototype for bnx2x_get_num_none_def_sbs(). Prototype was for
> bnx2x_get_num_non_def_sbs() instead
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4165: warning:
> expecting prototype for atomic_add_ifless(). Prototype was for
> __atomic_add_ifless() instead
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4193: warning:
> expecting prototype for atomic_dec_ifmoe(). Prototype was for
> __atomic_dec_ifmoe() instead
> 
> Cc: Ariel Elior <aelior@marvell.com>
> Cc: Sudarsana Kalluru <skalluru@marvell.com>
> Cc: GR-everest-linux-l2@marvell.com
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> index 281b1c2e04a7..2acbc73dcd18 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> @@ -13586,7 +13586,7 @@ static int bnx2x_set_qm_cid_count(struct bnx2x
> *bp)  }
> 
>  /**
> - * bnx2x_get_num_none_def_sbs - return the number of none default SBs
> + * bnx2x_get_num_non_def_sbs - return the number of none default SBs
>   * @pdev: pci device
>   * @cnic_cnt: count
>   *
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index 6cd1523ad9e5..542c69822649 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -4152,7 +4152,7 @@ void bnx2x_init_mcast_obj(struct bnx2x *bp,
>  /*************************** Credit handling
> **********************************/
> 
>  /**
> - * atomic_add_ifless - add if the result is less than a given value.
> + * __atomic_add_ifless - add if the result is less than a given value.
>   *
>   * @v:	pointer of type atomic_t
>   * @a:	the amount to add to v...
> @@ -4180,7 +4180,7 @@ static inline bool __atomic_add_ifless(atomic_t *v,
> int a, int u)  }
> 
>  /**
> - * atomic_dec_ifmoe - dec if the result is more or equal than a given value.
> + * __atomic_dec_ifmoe - dec if the result is more or equal than a given
> value.
>   *
>   * @v:	pointer of type atomic_t
>   * @a:	the amount to dec from v...
> --
> 2.17.1

Thanks for the changes.

Acked-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>

  reply	other threads:[~2021-05-19  9:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
2021-05-17  4:45 ` [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 02/24] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 03/24] net: atheros: atl1e: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 04/24] net: atheros: atl1x: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 05/24] net: broadcom: bnx2x: " Yang Shen
2021-05-19  9:30   ` Sudarsana Reddy Kalluru [this message]
2021-05-17  4:45 ` [PATCH v2 06/24] net: brocade: bna: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 07/24] net: cadence: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 08/24] net: calxeda: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 09/24] net: chelsio: cxgb3: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 10/24] net: chelsio: cxgb4: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 11/24] net: chelsio: cxgb4vf: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 12/24] net: huawei: hinic: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 13/24] net: micrel: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 14/24] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 15/24] net: neterion: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 16/24] net: neterion: vxge: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 17/24] net: netronome: nfp: " Yang Shen
2021-05-17 10:00   ` Simon Horman
2021-05-17  4:45 ` [PATCH v2 18/24] net: calxeda: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 19/24] net: samsung: sxgbe: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 20/24] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 21/24] net: ti: Fix wrong struct name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 22/24] net: via: Fix wrong function " Yang Shen
2021-05-17  4:45 ` [PATCH v2 23/24] net: phy: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 24/24] net: hisilicon: hns: Fix wrong function name in comments Yang Shen
2021-05-17 21:20 ` [PATCH v2 00/24] Rid W=1 warnings in net patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB403932EAA58A847383EA6E54D32B9@PH0PR18MB4039.namprd18.prod.outlook.com \
    --to=skalluru@marvell.com \
    --cc=GR-everest-linux-l2@marvell.com \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shenyang39@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).