From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Add sparse "__iomem" infrastructure to check PCI address usage
Date: Mon, 13 Sep 2004 16:22:10 +0200 (MEST) [thread overview]
Message-ID: <Pine.GSO.4.58.0409131616390.23648@waterleaf.sonytel.be> (raw)
In-Reply-To: <Pine.LNX.4.58.0409121945500.13491@ppc970.osdl.org>
While resuming adding __user annotations to the m68k-specific parts of the
code, I stumbled on
struct task_struct {
...
unsigned long sas_ss_sp;
...
}
If I'm not mistaken, sas_ss_sp is always a pointer to user stack space.
Shouldn't it be changed to `void __user *sas_ss_sp', or is an
unsigned long/void * change in generic code a too controversial change for
making sparse happy?
And I guess I can find a few more of these...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2004-09-13 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200409110726.i8B7QTGn009468@hera.kernel.org>
2004-09-13 0:26 ` Add sparse "__iomem" infrastructure to check PCI address usage Jeff Garzik
2004-09-13 0:50 ` David S. Miller
2004-09-13 2:31 ` Linus Torvalds
2004-09-13 2:41 ` Jeff Garzik
2004-09-13 3:00 ` Linus Torvalds
2004-09-13 14:22 ` Geert Uytterhoeven [this message]
2004-09-13 14:33 ` Linus Torvalds
2004-09-13 18:31 ` Tonnerre
2004-09-13 18:48 ` Linus Torvalds
2004-09-13 18:51 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.58.0409131616390.23648@waterleaf.sonytel.be \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).