linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@transmeta.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: Matthew Wilcox <matthew@wil.cx>, <linux-kernel@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>
Subject: Re: [Final call for testers][PATCH] superblock handling changes (2.4.6-pre3)
Date: Fri, 15 Jun 2001 12:12:02 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.31.0106151209470.7559-100000@penguin.transmeta.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0106151221190.8909-100000@weyl.math.psu.edu>



On Fri, 15 Jun 2001, Alexander Viro wrote:
> > > +	list_add (&s->s_list, super_blocks.prev);
> >
> > I'd use list_add_tail(&s->s_list, super_blocks);
>
> Umm... Why?

I have to agree with Matthew - "list_add_tail()" more clearly says what
the code is trying to do.

Aside from that, I will bet you a dollar that you'll see that using
"list_add_tail()" generating better code. Why? Simply because that way one
of the pointers is a constant, instead of being through indirection. Try
it and see.

And if order is arbitrary, please just use

	list_add(&s->s_list, super_blocks);

because otherwise why use the ".prev" at all?

		Linus


  parent reply	other threads:[~2001-06-15 19:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-12  4:29 [CFT][PATCH] superblock handling changes Alexander Viro
2001-06-12  3:22 ` Marcelo Tosatti
2001-06-12  5:17   ` Alexander Viro
2001-06-12  6:38 ` George Bonser
2001-06-13  4:50 ` [CFT][PATCH] superblock handling changes (2.4.6-pre3) Alexander Viro
2001-06-15  5:10   ` [Final call for testers][PATCH] " Alexander Viro
2001-06-15 16:16     ` Matthew Wilcox
2001-06-15 16:34       ` Alexander Viro
2001-06-15 16:41         ` Alexander Viro
2001-06-15 16:49         ` Matthew Wilcox
2001-06-15 19:12         ` Linus Torvalds [this message]
2001-06-15 19:18           ` Alexander Viro
2001-06-15 17:02     ` Jonathan Lundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.31.0106151209470.7559-100000@penguin.transmeta.com \
    --to=torvalds@transmeta.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).