From: Linus Torvalds <torvalds@transmeta.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Workqueue Abstraction, 2.5.40-H7
Date: Tue, 1 Oct 2002 12:16:12 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.33.0210011210030.1878-100000@penguin.transmeta.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0210011653370.28821-102000@localhost.localdomain>
On Tue, 1 Oct 2002, Ingo Molnar wrote:
>
> the attached (compressed) patch is the next iteration of the workqueue
> abstraction. There are two major categories of changes:
Pease don't introduce more typedefs. They only hide what the hell the
thing is, which is actively _bad_ for structures, since passing a
structure by value etc is something that should never be done, for
example.
The few saved characters of typing do not actually _buy_ you anything
else, and only obscures what the thing is.
Also, it's against the Linux coding standard, which does not like adding
magic single-letter suffixes to things - that also is the case for your
strange "_s" suffix for a structure (the real suffix is "_struct").
Remember: typing out something is not bad. It's _especially_ not bad if
the typing makes it more clear what the thing is.
I've done a global search-and-replace on the patch. The resulting patch is
actually _cleaner_, because it also matches more closely the old code
(which used "struct tq_struct"), so things like tabbed comment alignment
etc tend to be more correct (not always, but closer).
Linus
next prev parent reply other threads:[~2002-10-01 19:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-01 16:24 [patch] Workqueue Abstraction, 2.5.40-H7 Ingo Molnar
2002-10-01 17:55 ` Kai Germaschewski
2002-10-01 21:27 ` Ingo Molnar
2002-10-01 18:04 ` Jeff Garzik
2002-10-01 18:52 ` Ingo Molnar
2002-10-01 21:06 ` Jeff Garzik
2002-10-01 21:30 ` Ingo Molnar
2002-10-01 19:16 ` Linus Torvalds [this message]
2002-10-01 19:53 ` Linus Torvalds
2002-10-01 21:32 ` Kristian Hogsberg
2002-10-03 18:44 ` Ingo Molnar
2002-10-04 23:20 ` Kristian Hogsberg
2002-10-02 4:22 ` Christoph Hellwig
2002-10-01 21:31 ` Ingo Molnar
2002-10-02 8:22 ` Oleg Drokin
2002-10-08 3:50 ` Jeff Dike
2002-10-01 18:52 Marc-Christian Petersen
2002-10-02 3:58 ` Christoph Hellwig
2002-10-01 20:29 Ingo Molnar
2002-10-01 20:49 ` Linus Torvalds
2002-10-01 21:21 ` Ingo Molnar
2002-10-02 3:23 ` Miles Bader
2002-10-02 19:18 ` Randy.Dunlap
2002-10-01 21:09 ` Jes Sorensen
2002-10-01 21:35 ` Ingo Molnar
2002-10-03 1:38 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0210011210030.1878-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).