From: Thomas Horsten <thomas@horsten.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4.21-rc1: byteorder.h breaks with __STRICT_ANSI__ defined (trivial)
Date: Tue, 6 May 2003 11:16:45 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.40.0305061034030.8287-100000@jehova.dsm.dk> (raw)
Hi,
In 2.4.21-rc1 some inline functions are added to asm-i386/byteorder.h.
When __STRICT_ANSI__ is defined, __u64 doesn't get defined by
asm-i386/types.h, but it is used in one of the new inline functions,
__arch__swab64.
This causes files that use __STRICT_ANSI__ and include any file that
relies on byteorder.h to give a compile error:
make[4]: Entering directory `/var/tmp/portage/kdemultimedia-3.1.1/work/kdemultimedia-3.1.1/kioslave/audiocd'
/bin/sh ../../libtool --silent --mode=compile --tag=CXX g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/kde/3.1/include -I/usr/qt/3/include -I/usr/X11R6/include -DQT_THREAD_SUPPORT -D_REENTRANT -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -pedantic -W -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -DNDEBUG -DNO_DEBUG -O2 -mcpu=athlon-xp -O2 -pipe -fno-exceptions -fno-check-new -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -c -o audiocd.lo `test -f audiocd.cpp || echo './'`audiocd.cpp
In file included from /usr/include/linux/cdrom.h:14,
from audiocd.cpp:57:
/usr/include/asm/byteorder.h:38: syntax error before `(' token
[.....]
The following patch fixes the problem:
--- linux-2.4.21-rc1-orig/include/asm-i386/byteorder.h 2003-05-06 09:52:33.000000000 +0100
+++ linux-2.4.21-rc1-ac4-th/include/asm-i386/byteorder.h 2003-05-06 09:51:13.000000000 +0100
@@ -34,7 +34,7 @@
return x;
}
-
+#ifndef __STRICT_ANSI__
static inline __u64 ___arch__swab64(__u64 val)
{
union {
@@ -53,12 +53,17 @@
#endif
return v.u;
}
+#endif /* !__STRICT_ANSI__ */
+#ifndef __STRICT_ANSI__
#define __arch__swab64(x) ___arch__swab64(x)
+#endif
#define __arch__swab32(x) ___arch__swab32(x)
#define __arch__swab16(x) ___arch__swab16(x)
+#ifndef __STRICT_ANSI__
#define __BYTEORDER_HAS_U64__
+#endif
#endif /* __GNUC__ */
// Thomas
next reply other threads:[~2003-05-06 9:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 9:16 Thomas Horsten [this message]
2003-05-06 9:19 ` [PATCH] 2.4.21-rc1: byteorder.h breaks with __STRICT_ANSI__ defined (trivial) David S. Miller
2003-05-06 9:38 ` Christoph Hellwig
2003-05-06 9:47 ` Thomas Horsten
2003-05-06 9:49 ` Christoph Hellwig
2003-05-06 10:03 ` David S. Miller
2003-05-06 14:10 ` Thomas Horsten
2003-05-06 13:06 ` David S. Miller
2003-05-06 15:40 ` Thomas Horsten
2003-05-07 5:50 ` ismail (cartman) donmez
2003-05-07 6:44 ` Thomas Horsten
2003-05-07 6:45 ` Christoph Hellwig
2003-05-07 5:44 ` David S. Miller
2003-05-07 6:55 ` Christoph Hellwig
2003-05-07 6:59 ` Thomas Horsten
2003-05-07 5:53 ` David S. Miller
2003-05-06 21:19 ` David Woodhouse
2003-05-07 3:06 ` David S. Miller
2003-05-07 5:26 ` Christoph Hellwig
2003-05-07 5:07 ` David S. Miller
2003-05-07 6:20 ` Christoph Hellwig
2003-05-07 5:19 ` David S. Miller
2003-05-07 6:28 ` Christoph Hellwig
2003-05-07 5:27 ` David S. Miller
2003-05-07 6:41 ` Christoph Hellwig
2003-05-07 5:42 ` David S. Miller
[not found] <20030506110259.A29633@infradead.org>
2003-05-06 10:24 ` Thomas Horsten
2003-11-06 17:36 Martin Schlemmer
2003-11-06 17:37 ` David S. Miller
2003-11-06 18:32 ` Martin Schlemmer
2003-11-06 18:42 ` Martin Schlemmer
2003-11-06 19:37 ` David S. Miller
2003-11-06 20:09 ` Martin Schlemmer
2003-11-06 20:05 ` David S. Miller
2003-11-06 20:29 ` Martin Schlemmer
2003-11-06 20:27 ` David S. Miller
2003-11-06 21:18 ` Martin Schlemmer
2003-11-06 21:18 ` David S. Miller
2003-11-06 21:59 ` Martin Schlemmer
2003-11-06 21:24 ` Daniel Jacobowitz
2003-11-06 20:40 ` H. Peter Anvin
2003-11-06 22:31 ` David S. Miller
2003-11-06 23:40 ` H. Peter Anvin
2003-11-06 21:21 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.40.0305061034030.8287-100000@jehova.dsm.dk \
--to=thomas@horsten.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).