From: Ingo Molnar <mingo@elte.hu>
To: linas@austin.ibm.com
Cc: Andrew Morton <akpm@osdl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Race in 2.6.0-test2 timer code
Date: Fri, 1 Aug 2003 08:23:26 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.44.0308010819510.19862-100000@localhost.localdomain> (raw)
In-Reply-To: <20030731175605.A26460@forte.austin.ibm.com>
On Thu, 31 Jul 2003 linas@austin.ibm.com wrote:
> Well, I'm confused by this a bit too, now. I saw this bug in 2.4 and I
> thought that Andrea was implying that it couldn't happen in 2.6. He
> seemed to be saying that the del_timer_sync() + add_timer() race can
> happen only in 2.4, where add_timer() is running on the 'wrong' cpu
> bacuase it got there through the evil run_all_timers()/TIMER_BH. Since
> there's no run_all_timers() in 2.6, he seemed to imply that the race
> 'couldn't happen'. Is he right?
it is correct, but it was me convincing Andrea about this, not the other
way around :-) Pls. re-read the email thread. My point still stands:
>> (in any case, i still think it would be safer to 'upgrade' the
>> add_timer() interface to be SMP-safe and to allow double-adds - but not
>> for any bug reason anymore.)
this should also make backporting easier.
Ingo
prev parent reply other threads:[~2003-08-01 6:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-29 15:41 PATCH: Race in 2.6.0-test2 timer code linas
2003-07-29 20:56 ` Andrew Morton
2003-07-30 5:57 ` Ingo Molnar
2003-07-30 6:36 ` Andrew Morton
2003-07-30 7:07 ` Ingo Molnar
2003-07-30 7:34 ` Andrea Arcangeli
2003-07-30 7:34 ` Ingo Molnar
2003-07-30 8:28 ` Andrea Arcangeli
2003-07-30 10:31 ` Ingo Molnar
2003-07-30 11:16 ` Andrea Arcangeli
2003-07-30 11:49 ` Ingo Molnar
2003-07-30 12:34 ` Andrea Arcangeli
2003-07-30 21:18 ` linas
2003-07-30 22:06 ` Andrea Arcangeli
2003-07-30 22:17 ` Andrea Arcangeli
2003-07-31 7:04 ` Ingo Molnar
2003-07-30 21:19 ` Andrea Arcangeli
2003-07-30 23:43 ` linas
2003-07-30 23:56 ` Andrea Arcangeli
2003-07-30 23:54 ` Andrew Morton
2003-07-31 0:16 ` Andrea Arcangeli
2003-07-31 17:23 ` linas
2003-08-01 6:27 ` Ingo Molnar
2003-07-30 7:40 ` Ingo Molnar
2003-07-30 8:37 ` Andrea Arcangeli
2003-07-30 10:34 ` Ingo Molnar
2003-07-30 10:51 ` Andrew Morton
2003-07-30 11:28 ` Andrea Arcangeli
2003-07-30 11:22 ` Andrea Arcangeli
2003-07-30 20:05 ` linas
2003-07-31 6:50 ` Ingo Molnar
2003-07-31 22:56 ` linas
2003-08-01 6:23 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0308010819510.19862-100000@localhost.localdomain \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).