Re: Totally broken PCI PM calls

[Linus Torvalds <torvalds@osdl.org>]

On Mon, 11 Oct 2004, Benjamin Herrenschmidt wrote:
> 
> But radeonfb ends up suspending the display at a wrong time and you miss
> half of the output, which makes any kind of debugging near to
> impossible.

Agreed.

But notice? It _works_. It's suspendign too damn eagerly, and it's hard to
debug, but it's a "safe" solution to the confusion that does exist. Which
is why I did it.

And please do realize that I'd love to solve the confusion, and remove the
hack. It's a hack, I admit it.  But it's better than just saying "be
confused, be broken, I don't care".

If the hack ends up motivating somebody (hint hint) to solve the problem 
properly, I'll be really happy. Paul suggested one solution (don't call 
down to suspend at all - which is also a hack, but I suspect it might be 
about as good a hack as the current one). I suggested another: using type 
checking to make sure drivers _aren't_ confused. 

The more the merrier. Care to come up with a solution of your own?

And no, I'm not interested in the type "let's fix one driver" kind of 
thing. That's what we've had for the last year or more, and the fact is, 
my laptop _never_ suspended during that time. So I really think it needs a 
_proper_ solution.

		Linus