From: Roman Zippel <zippel@linux-m68k.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, jbeulich@novell.com
Subject: Re: Subject: [PATCH] reintegrate irqreturn.h into hardirq.h
Date: Sat, 24 Jun 2006 17:34:21 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0606241731340.12900@scrub.home> (raw)
In-Reply-To: <adawtb6k3dz.fsf@cisco.com>
Hi,
On Sat, 24 Jun 2006, Roland Dreier wrote:
> > -extern fastcall irqreturn_t handle_IRQ_event(unsigned int irq, struct pt_regs *regs,
> > +extern fastcall int handle_IRQ_event(unsigned int irq, struct pt_regs *regs,
> > struct irqaction *action);
>
> This seems like a step backwards: this changes the declaration of
> handle_IRQ_event() so it no longer matches the real definition.
Then it's better to change the definition back as well, we generally want
to avoid typedefs and this one is only a compatibility typedef meant for
drivers.
bye, Roman
prev parent reply other threads:[~2006-06-24 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 17:45 Subject: [PATCH] reintegrate irqreturn.h into hardirq.h Roman Zippel
2006-06-24 14:57 ` Roland Dreier
2006-06-24 15:34 ` Roman Zippel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606241731340.12900@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).