From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: somebody dropped a (warning) bomb
Date: Thu, 8 Feb 2007 08:33:30 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702080819350.8424@woody.linux-foundation.org> (raw)
In-Reply-To: <45CB3B28.60102@garzik.org>
On Thu, 8 Feb 2007, Jeff Garzik wrote:
>
> Just did a pull for the first time since 2.6.20, and a /megaton/ of new
> warnings have appeared, on Fedora Core 6/x86-64 "make allyesconfig".
That was due to the Makefile rule breakage. Hopefully it now _really_ is
fixed. The
CFLAGS += $(call cc-option,-Wno-pointer-sign,)
part effectively got dropped.
> All of the new warnings spew appear to be "pointers differ in signedness"
> warning. Granted, we should care about these
The thing is, I'm _really_ sad we have to use that -Wno-pointer-sign
thing. It's a real and valid warning. It finds really ugly code issues
(unlike a lot of the other things). So it got dropped by mistake, but that
is one warning that I'd actually like to resurrect (unlike a lot of other
gcc warnings that I just think are crap to begin with).
However, we've got a metric shitload of code that passes in pointers to
the wrong sign, so a lot of it would involve mindless changes that are
likely to break real things.
And the thing is, sometimes -Wpointer-sign-compare is just horribly
broken. For example, you cannot write a "strlen()" that doesn't complain
about "unsigned char *" vs "char *". And that is just a BUG.
I'm continually amazed at how totally clueless some gcc warnings are.
You'd think that the people writing them are competent. And then sometimes
they show just how totally incompetent they are, by making it impossible
to use "unsigned char" arrays together with standard functions.
So a _lot_ of the warnings are real. But with no way to shut up the ones
that aren't, it sadly doesn't matter one whit ;(
(And adding casts is just much worse than shutting up the warning
entirely)
There should be a rule about warnings: if you can't shut up stylistic
warnings on a site-by-site level without adding horribly syntactic stuff
that is worse than what the warning is all about, the warning shouldn't
exist.
Linus
next prev parent reply other threads:[~2007-02-08 16:33 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 15:00 somebody dropped a (warning) bomb Jeff Garzik
2007-02-08 16:33 ` Linus Torvalds [this message]
2007-02-08 18:42 ` Jan Engelhardt
2007-02-08 19:53 ` Linus Torvalds
2007-02-08 21:10 ` Jan Engelhardt
2007-02-08 21:37 ` Linus Torvalds
2007-02-08 23:12 ` David Rientjes
2007-02-08 23:37 ` Linus Torvalds
2007-02-09 0:24 ` David Rientjes
2007-02-09 0:42 ` Linus Torvalds
2007-02-09 0:59 ` Linus Torvalds
2007-02-09 0:59 ` David Rientjes
2007-02-09 1:11 ` Linus Torvalds
2007-02-09 1:18 ` David Rientjes
2007-02-09 15:38 ` Linus Torvalds
2007-02-09 3:27 ` D. Hazelton
2007-02-09 19:54 ` Pete Zaitcev
2007-02-09 12:34 ` Jan Engelhardt
2007-02-09 13:16 ` linux-os (Dick Johnson)
2007-02-09 17:45 ` Jan Engelhardt
2007-02-09 20:29 ` linux-os (Dick Johnson)
2007-02-09 22:05 ` Jan Engelhardt
2007-02-09 22:58 ` Martin Mares
2007-02-12 18:50 ` linux-os (Dick Johnson)
2007-02-13 15:14 ` Dick Streefland
2007-02-08 21:13 ` J.A. Magallón
2007-02-08 21:42 ` Linus Torvalds
2007-02-08 22:03 ` Linus Torvalds
2007-02-08 22:19 ` Willy Tarreau
2007-02-09 0:03 ` J.A. Magallón
2007-02-09 0:22 ` Linus Torvalds
2007-02-09 12:38 ` Sergei Organov
2007-02-09 15:58 ` Linus Torvalds
2007-02-12 11:12 ` Sergei Organov
2007-02-12 16:26 ` Linus Torvalds
2007-02-13 18:06 ` Sergei Organov
2007-02-13 18:26 ` Pekka Enberg
2007-02-13 19:14 ` Sergei Organov
2007-02-13 19:43 ` Pekka Enberg
2007-02-13 20:29 ` Sergei Organov
2007-02-13 21:31 ` Jeff Garzik
2007-02-13 23:21 ` Linus Torvalds
2007-02-15 13:20 ` Sergei Organov
2007-02-15 15:57 ` Linus Torvalds
2007-02-15 18:53 ` Sergei Organov
2007-02-15 19:02 ` Linus Torvalds
2007-02-15 20:23 ` me, not " Oleg Verych
2007-02-16 4:26 ` Rene Herman
2007-02-19 11:58 ` Sergei Organov
2007-02-19 13:58 ` Sergei Organov
2007-02-15 22:32 ` Lennart Sorensen
2007-02-13 19:25 ` Linus Torvalds
2007-02-13 19:59 ` Sergei Organov
2007-02-13 20:24 ` Linus Torvalds
2007-02-15 15:15 ` Sergei Organov
2007-02-13 21:13 ` Rob Landley
2007-02-13 22:21 ` Olivier Galibert
2007-02-14 12:52 ` Sergei Organov
2007-02-15 20:06 ` Sergei Organov
2007-02-09 15:10 ` Sergei Organov
2007-02-08 16:35 ` Kumar Gala
[not found] <7Mj5f-3oz-21@gated-at.bofh.it>
[not found] ` <7MktH-5EW-35@gated-at.bofh.it>
[not found] ` <7Mmvy-vj-17@gated-at.bofh.it>
[not found] ` <7MnBC-2fk-13@gated-at.bofh.it>
[not found] ` <7MoQx-4p8-11@gated-at.bofh.it>
[not found] ` <7MpjE-50z-7@gated-at.bofh.it>
[not found] ` <7MpCS-5Fe-9@gated-at.bofh.it>
[not found] ` <7MDd7-17w-1@gated-at.bofh.it>
[not found] ` <7MGkB-62k-31@gated-at.bofh.it>
[not found] ` <7NHoe-2Mb-37@gated-at.bofh.it>
[not found] ` <7NMe9-1ZN-7@gated-at.bofh.it>
[not found] ` <7Oagl-6bO-1@gated-at.bofh.it>
[not found] ` <7ObvW-89N-23@gated-at.bofh.it>
[not found] ` <7Oc8t-NS-1@gated-at.bofh.it>
2007-02-15 20:08 ` Bodo Eggert
2007-02-16 11:21 ` Sergei Organov
2007-02-16 14:51 ` Bodo Eggert
2007-02-19 11:56 ` Sergei Organov
2007-02-16 12:46 ` Sergei Organov
2007-02-16 17:40 ` Bodo Eggert
2007-02-19 12:17 ` Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702080819350.8424@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).