From: Adrian Bunk <bunk@fs.tum.de>
To: Linus Torvalds <torvalds@transmeta.com>, Eric Sandeen <sandeen@sgi.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux v2.5.32
Date: Wed, 28 Aug 2002 19:21:23 +0200 (CEST) [thread overview]
Message-ID: <Pine.NEB.4.44.0208281916350.2879-100000@mimas.fachschaften.tu-muenchen.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0208271239580.2564-100000@penguin.transmeta.com>
On Tue, 27 Aug 2002, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.31 to v2.5.32
> ============================================
>...
> Eric Sandeen <sandeen@sgi.com>:
> o Remove unused var and unused func from ali-ircc IrDA driver
>...
This change removes the variable "ret" but not it's use:
<-- snip -->
...
gcc -Wp,-MD,./.ali-ircc.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2
.5.32-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fomit-frame-poi
nter -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=
k6 -nostdinc -iwithprefix include -DKBUILD_BASENAME=ali_ircc -c -o
ali-ircc
.o ali-ircc.c
ali-ircc.c: In function `ali_ircc_open':
ali-ircc.c:286: `ret' undeclared (first use in this function)
ali-ircc.c:286: (Each undeclared identifier is reported only once
ali-ircc.c:286: for each function it appears in.)
...
make[3]: *** [ali-ircc.o] Error 1
make[3]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.32-full/drivers/net/irda'
<-- snip -->
-dj contains the following to remove the use of ret:
--- drivers/net/irda/ali-ircc.c.old 2002-08-28 19:15:38.000000000 +0200
+++ drivers/net/irda/ali-ircc.c 2002-08-28 19:15:40.000000000 +0200
@@ -283,15 +283,13 @@
self->io.fifo_size = 16; /* SIR: 16, FIR: 32 Benjamin 2000/11/1 */
/* Reserve the ioports that we need */
- ret = check_region(self->io.fir_base, self->io.fir_ext);
- if (ret < 0) {
+ if (!request_region(self->io.fir_base, self->io.fir_ext, driver_name)) {
WARNING(__FUNCTION__ "(), can't get iobase of 0x%03x\n",
self->io.fir_base);
dev_self[i] = NULL;
kfree(self);
return -ENODEV;
}
- request_region(self->io.fir_base, self->io.fir_ext, driver_name);
/* Initialize QoS for this device */
irda_init_max_qos_capabilies(&self->qos);
cu
Adrian
--
You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox
next prev parent reply other threads:[~2002-08-28 17:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-27 19:47 Linux v2.5.32 Linus Torvalds
2002-08-27 20:22 ` Stephane Wirtel
2002-08-27 20:36 ` Thunder from the hill
2002-08-27 20:48 ` Stephane Wirtel
2002-08-27 20:54 ` Gabor Z. Papp
2002-08-28 6:18 ` Jan-Benedict Glaw
2002-08-28 7:41 ` Edward Coffey
2002-08-28 8:35 ` Russell King
2002-08-27 20:43 ` Udo A. Steinberg
2002-08-27 20:47 ` Andre Hedrick
2002-08-27 20:47 ` Alexander Viro
2002-08-27 22:35 ` Alan Cox
2002-08-28 2:07 ` [PATCH] " Alexander Viro
2002-08-28 1:21 ` Arador
2002-08-28 2:17 ` Alexander Viro
2002-08-27 22:28 ` Chris Funderburg (at home)
2002-08-28 7:31 ` Linux v2.5.32 - some menuconfig oddities Helge Hafting
2002-08-28 7:43 ` Gabor Kerenyi
2002-08-28 8:14 ` Linux v2.5.32 Edward Coffey
2002-08-28 8:17 ` Writing files to remote storage Kevin Liao
2002-08-28 14:18 ` Alan Cox
2002-08-28 13:00 ` 2.5.32 doesn't beep? Mikael Pettersson
2002-08-28 13:05 ` Vojtech Pavlik
2002-08-28 13:12 ` Mikael Pettersson
2002-08-28 13:58 ` Gerhard Mack
2002-08-28 14:33 ` Jos Hulzink
2002-08-28 14:49 ` Vojtech Pavlik
2002-08-28 20:04 ` Mikael Pettersson
2002-08-28 20:30 ` Vojtech Pavlik
2002-08-29 8:41 ` Gerd Knorr
2002-08-28 17:21 ` Adrian Bunk [this message]
2002-08-31 16:54 ` Linux v2.5.32 (Config options to have a working keyboard) Axel Siebenwirth
2002-08-27 23:50 Linux v2.5.32 Michel Eyckmans (MCE)
2002-08-28 0:43 rwhron
2002-08-28 1:15 ` Andre Hedrick
2002-08-28 2:21 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.NEB.4.44.0208281916350.2879-100000@mimas.fachschaften.tu-muenchen.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sgi.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).