From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Andrew Morton <akpm@digeo.com>
Cc: Andries Brouwer <aebr@win.tue.nl>, <alan@lxorguk.ukuu.org.uk>,
<andre@linux-ide.org>, <axboe@suse.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4)
Date: Thu, 24 Apr 2003 02:02:15 +0200 (MET DST) [thread overview]
Message-ID: <Pine.SOL.4.30.0304240142580.22047-100000@mion.elka.pw.edu.pl> (raw)
In-Reply-To: <20030423162041.1b7ee5b3.akpm@digeo.com>
On Wed, 23 Apr 2003, Andrew Morton wrote:
> Andries Brouwer <aebr@win.tue.nl> wrote:
> >
> > On Wed, Apr 23, 2003 at 03:35:00PM -0700, Andrew Morton wrote:
> >
> > > What is special about the IDE ioctl approach?
> >
> > Usually one wants to use the standard commands for I/O.
> > But if the purpose is to talk to the drive (set password,
> > set native max, eject, change ZIP drive from big floppy
> > mode to removable disk mode, etc. etc.) then one needs
> > a means to execute IDE commands "by hand".
>
> Yes, but none of these are performance-critical and they don't involve
> large amnounts of data. A copy is OK.
low-level benchmarking is somehow performance critical :-)
note that direct-IO here is _only_ bonus, main goal is to
use the same code for _all_ ioctl and fs generated IDE IO
(remember that all fs IDE IO is rq->bio based)
and this is work-in-progress...
> If all the rework against bio_map_user() and friends is needed for other
> reasons then fine. But it doesn't seem to be needed for the IDE taskfile
> ioctl.
Rework of bio_map_user() and co. is minimal and not needed but otherwise
I will have to duplicate same code in 4 places. bio_map_user() now does
allocated bio checking and grabs extra reference to bio which all users of
old bio_map_user() have to do anyway (and they will probably forgot to).
next prev parent reply other threads:[~2003-04-23 23:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 17:37 [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4) Bartlomiej Zolnierkiewicz
2003-04-23 17:38 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (1/4) Bartlomiej Zolnierkiewicz
2003-04-24 8:23 ` Jens Axboe
2003-04-24 14:46 ` Bartlomiej Zolnierkiewicz
2003-04-24 15:47 ` [PATCH] 2.5.68 fix mismatched access_ok() checks in sg_io() Bartlomiej Zolnierkiewicz
2003-04-24 17:31 ` Jens Axboe
2003-04-23 17:39 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (2/4) Bartlomiej Zolnierkiewicz
2003-04-23 17:39 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (3/4) Bartlomiej Zolnierkiewicz
2003-04-23 17:40 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (4/4) Bartlomiej Zolnierkiewicz
2003-04-24 7:56 ` Jens Axboe
2003-04-23 18:24 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4) [resend] Bartlomiej Zolnierkiewicz
2003-04-23 22:35 ` [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4) Andrew Morton
2003-04-23 22:09 ` Alan Cox
2003-04-23 22:58 ` Bartlomiej Zolnierkiewicz
2003-04-23 23:13 ` Andries Brouwer
2003-04-23 23:20 ` Andrew Morton
2003-04-24 0:02 ` Bartlomiej Zolnierkiewicz [this message]
2003-04-24 6:55 ` Jens Axboe
2003-04-24 2:27 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SOL.4.30.0304240142580.22047-100000@mion.elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=aebr@win.tue.nl \
--cc=akpm@digeo.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).