From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Bo YU <tsu.yubo@gmail.com>, "clm@fb.com" <clm@fb.com>,
"josef@toxicpanda.com" <josef@toxicpanda.com>,
"sterba@suse.com" <sterba@suse.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] fs/btrfs: Fix unlocking in btrfs_ref_tree_mod
Date: Fri, 15 May 2020 09:03:29 +0000 [thread overview]
Message-ID: <SN4PR0401MB35985CFC199D20362EBFD8E09BBD0@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200515021731.cb5y557wsxf66fo3@debian.debian-2
On 15/05/2020 04:17, Bo YU wrote:
> It adds spin_lock() in add_block_entry() but out path does not unlock
> it.
Which call path doesn't unlock it? There is an out_unlock label with a
spin_unlock() right above your insert. So either coverity messed something
up or the call path that needs the unlock has to jump to out_unlock instead
of out.
next prev parent reply other threads:[~2020-05-15 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 2:17 [PATCH -next] fs/btrfs: Fix unlocking in btrfs_ref_tree_mod Bo YU
2020-05-15 9:03 ` Johannes Thumshirn [this message]
2020-05-15 9:23 ` Bo YU
2020-05-15 9:36 ` Johannes Thumshirn
2020-05-15 10:44 ` Bo YU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB35985CFC199D20362EBFD8E09BBD0@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=clm@fb.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sterba@suse.com \
--cc=tsu.yubo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).