Re: [PATCH 1/2] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.

[Paul Cercueil <paul@crapouillou.net>]

Hi Zhou,

Le sam., juil. 24 2021 at 20:52:30 +0800, Zhou Yanjie 
<zhouyanjie@wanyeetech.com> a écrit :
> Hi Paul,
> 
> On 2021/7/24 下午6:46, Paul Cercueil wrote:
>> Hi Zhou,
>> 
>> Le sam., juil. 24 2021 at 16:48:40 +0800, 周琰杰 (Zhou Yanjie) 
>> \x7f<zhouyanjie@wanyeetech.com> a écrit :
>>> Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000 
>>> SoC,
>>> the X1600 SoC, the X1830 SoC, and the X2000 SoC from Ingenic.
>>> 
>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>>> ---
>>>  Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>> 
>>> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml 
>>> \x7f\x7fb/Documentation/devicetree/bindings/usb/dwc2.yaml
>>> index 10c7d9b..e779d33 100644
>>> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
>>> @@ -14,6 +14,12 @@ properties:
>>>      oneOf:
>>>        - const: brcm,bcm2835-usb
>>>        - const: hisilicon,hi6220-usb
>>> +      - const: ingenic,jz4775-otg
>>> +      - const: ingenic,jz4780-otg
>>> +      - const: ingenic,x1000-otg
>>> +      - const: ingenic,x1600-otg
>>> +      - const: ingenic,x1830-otg
>>> +      - const: ingenic,x2000-otg
>> 
>> I don't know if all these IPs are the exact same, but if they are, 
>> \x7fthey all should have "ingenic,jz4775-otg" as the fallback.
> 
> 
> I'm not too sure whether they are exactly the same, but comparing the 
> code in Ingenics SDK,
> 
> the code of the USB part of jz4775, jz4780, and x1000 are the same, 
> the code of the USB part
> 
> of x1600 and x1830 are the same, and the USB part code of X2000 are 
> different from all of them.

In doubt - it's better to keep separate compatible strings, so this is 
OK.

Cheers,
-Paul