RE: [PATCH v6 40/57] soc: Remove dev_err() usage after platform_get_irq()

From: Leo Li <leoyang.li@nxp.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Gross <andy.gross@linaro.org>,
	Thierry Reding <treding@nvidia.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v6 40/57] soc: Remove dev_err() usage after platform_get_irq()
Date: Tue, 30 Jul 2019 21:26:01 +0000	[thread overview]
Message-ID: <VE1PR04MB668744C680C7AC2498AE9A478FDC0@VE1PR04MB6687.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190730183503.GX7234@tuxbook-pro>

> -----Original Message-----
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
> Sent: Tuesday, July 30, 2019 1:35 PM
> To: Stephen Boyd <swboyd@chromium.org>
> Cc: linux-kernel@vger.kernel.org; Andy Gross <andy.gross@linaro.org>;
> Thierry Reding <treding@nvidia.com>; Leo Li <leoyang.li@nxp.com>; Simon
> Horman <horms+renesas@verge.net.au>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>
> Subject: Re: [PATCH v6 40/57] soc: Remove dev_err() usage after
> platform_get_irq()
> 
> On Tue 30 Jul 11:15 PDT 2019, Stephen Boyd wrote:
> 
> > We don't need dev_err() messages when platform_get_irq() fails now
> > that
> > platform_get_irq() prints an error message itself when something goes
> > wrong. Let's remove these prints with a simple semantic patch.
> >
> > // <smpl>
> > @@
> > expression ret;
> > struct platform_device *E;
> > @@
> >
> > ret =
> > (
> > platform_get_irq(E, ...)
> > |
> > platform_get_irq_byname(E, ...)
> > );
> >
> > if ( \( ret < 0 \| ret <= 0 \) )
> > {
> > (
> > -if (ret != -EPROBE_DEFER)
> > -{ ...
> > -dev_err(...);
> > -... }
> > |
> > ...
> > -dev_err(...);
> > )
> > ...
> > }
> > // </smpl>
> >
> > While we're here, remove braces on if statements that only have one
> > statement (manually).
> >
> > Cc: Andy Gross <andy.gross@linaro.org>
> > Cc: Thierry Reding <treding@nvidia.com>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> > Cc: Li Yang <leoyang.li@nxp.com>
> > Cc: Simon Horman <horms+renesas@verge.net.au>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > ---
> >
> > Please apply directly to subsystem trees
> >
> >  drivers/soc/fsl/qbman/bman_portal.c | 4 +---
> > drivers/soc/fsl/qbman/qman_portal.c | 4 +---
> >  drivers/soc/qcom/smp2p.c            | 4 +---
> 
> If you had split this in a fsl and a qcom patch I would have just merged the
> latter.
> 
> I don't see a problem with Li taking this patch through the Freescale tree
> though (or vise versa).

The patch looks good to me too.  I can take it through my tree with your reviewed-by.

Regards,
Leo
> 
> Regards,
> Bjorn
> 
> >  3 files changed, 3 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/soc/fsl/qbman/bman_portal.c
> > b/drivers/soc/fsl/qbman/bman_portal.c
> > index cf4f10d6f590..e4ef35abb508 100644
> > --- a/drivers/soc/fsl/qbman/bman_portal.c
> > +++ b/drivers/soc/fsl/qbman/bman_portal.c
> > @@ -135,10 +135,8 @@ static int bman_portal_probe(struct
> platform_device *pdev)
> >  	pcfg->cpu = -1;
> >
> >  	irq = platform_get_irq(pdev, 0);
> > -	if (irq <= 0) {
> > -		dev_err(dev, "Can't get %pOF IRQ'\n", node);
> > +	if (irq <= 0)
> >  		goto err_ioremap1;
> > -	}
> >  	pcfg->irq = irq;
> >
> >  	pcfg->addr_virt_ce = memremap(addr_phys[0]->start, diff --git
> > a/drivers/soc/fsl/qbman/qman_portal.c
> > b/drivers/soc/fsl/qbman/qman_portal.c
> > index e2186b681d87..991c35a72e00 100644
> > --- a/drivers/soc/fsl/qbman/qman_portal.c
> > +++ b/drivers/soc/fsl/qbman/qman_portal.c
> > @@ -275,10 +275,8 @@ static int qman_portal_probe(struct
> platform_device *pdev)
> >  	pcfg->channel = val;
> >  	pcfg->cpu = -1;
> >  	irq = platform_get_irq(pdev, 0);
> > -	if (irq <= 0) {
> > -		dev_err(dev, "Can't get %pOF IRQ\n", node);
> > +	if (irq <= 0)
> >  		goto err_ioremap1;
> > -	}
> >  	pcfg->irq = irq;
> >
> >  	pcfg->addr_virt_ce = memremap(addr_phys[0]->start, diff --git
> > a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index
> > c7300d54e444..07183d731d74 100644
> > --- a/drivers/soc/qcom/smp2p.c
> > +++ b/drivers/soc/qcom/smp2p.c
> > @@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct
> platform_device *pdev)
> >  		goto report_read_failure;
> >
> >  	irq = platform_get_irq(pdev, 0);
> > -	if (irq < 0) {
> > -		dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n");
> > +	if (irq < 0)
> >  		return irq;
> > -	}
> >
> >  	smp2p->mbox_client.dev = &pdev->dev;
> >  	smp2p->mbox_client.knows_txdone = true;
> > --
> > Sent by a computer through tubes
> >