From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: Sheng Long Wang <shenglong.wang.ext@siemens.com>,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH 0/6] USB: serial: cp210x: clean up termios handling
Date: Fri, 4 Dec 2020 14:59:44 +0100 [thread overview]
Message-ID: <X8pA0PBuFFKUBTwV@localhost> (raw)
In-Reply-To: <20201116161826.29417-1-johan@kernel.org>
On Mon, Nov 16, 2020 at 05:18:20PM +0100, Johan Hovold wrote:
> Unlike other drivers cp210x have been retrieving the current terminal
> settings from the device on open and reflecting those in termios.
>
> Due to how set_termios() was implemented this saved a few control
> requests on open but has instead caused problems like broken flow
> control and has required adding workarounds for swapped line-control in
> cp2108 and line-speed initialisation on cp2104.
>
> This unusual implementation also complicates adding new features for no
> good reason.
>
> Rip out the corresponding code and the above mentioned workarounds and
> instead initialise the terminal settings unconditionally on open.
> Johan Hovold (6):
> USB: serial: cp210x: return early on unchanged termios
> USB: serial: cp210x: clean up line-control handling
> USB: serial: cp210x: set terminal settings on open
> USB: serial: cp210x: drop flow-control debugging
> USB: serial: cp210x: refactor flow-control handling
> USB: serial: cp210x: clean up dts_rts
>
> drivers/usb/serial/cp210x.c | 499 ++++++++----------------------------
> 1 file changed, 104 insertions(+), 395 deletions(-)
I have applied this series for -next now.
Johan
prev parent reply other threads:[~2020-12-04 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 16:18 [PATCH 0/6] USB: serial: cp210x: clean up termios handling Johan Hovold
2020-11-16 16:18 ` [PATCH 1/6] USB: serial: cp210x: return early on unchanged termios Johan Hovold
2020-11-16 16:18 ` [PATCH 2/6] USB: serial: cp210x: clean up line-control handling Johan Hovold
2020-11-16 16:18 ` [PATCH 3/6] USB: serial: cp210x: set terminal settings on open Johan Hovold
2020-11-16 16:18 ` [PATCH 4/6] USB: serial: cp210x: drop flow-control debugging Johan Hovold
2020-11-16 16:18 ` [PATCH 5/6] USB: serial: cp210x: refactor flow-control handling Johan Hovold
2020-11-16 16:18 ` [PATCH 6/6] USB: serial: cp210x: clean up dts_rts Johan Hovold
2020-12-04 13:59 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8pA0PBuFFKUBTwV@localhost \
--to=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shenglong.wang.ext@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).