From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ikjoon Jang <ikjn@chromium.org>
Cc: linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org,
Zhanyong Wang <zhanyong.wang@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Tianping Fang <tianping.fang@mediatek.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] usb: xhci-mtk: fix unreleased bandwidth data
Date: Thu, 10 Dec 2020 11:58:45 +0100 [thread overview]
Message-ID: <X9H/ZVpHf2Owd6rj@kroah.com> (raw)
In-Reply-To: <20201210184700.v2.3.Id0d31b5f3ddf5e734d2ab11161ac5821921b1e1e@changeid>
On Thu, Dec 10, 2020 at 06:47:47PM +0800, Ikjoon Jang wrote:
> xhci-mtk has hooks on add_endpoint() and drop_endpoint() from xhci
> to handle its own sw bandwidth managements and stores bandwidth data
> into internal table every time add_endpoint() is called,
> so when bandwidth allocation fails at one endpoint, all earlier
> allocation from the same interface could still remain at the table.
>
> This patch adds two more hooks from check_bandwidth() and
> reset_bandwidth(), and make mtk-xhci to releases all failed endpoints
> from reset_bandwidth().
>
> Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Shouldn't this be the first patch in the series? You don't want a fix
to be dependent on code style changes, otherwise it is really really
hard to backport it to older kernels that might need this fix, right?
Can you re-order these patches please?
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-10 11:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 10:47 [PATCH v2 0/3] Release allocated periodic bandwidth data from reset_bandwidth() Ikjoon Jang
2020-12-10 10:47 ` [PATCH v2 1/3] usb: xhci-mtk: code cleanups in getting bandwidth table Ikjoon Jang
2020-12-10 10:47 ` [PATCH v2 2/3] usb: xhci-mtk: delay association of tt and ep Ikjoon Jang
2020-12-10 10:59 ` Greg Kroah-Hartman
2020-12-10 10:47 ` [PATCH v2 3/3] usb: xhci-mtk: fix unreleased bandwidth data Ikjoon Jang
2020-12-10 10:58 ` Greg Kroah-Hartman [this message]
2020-12-11 6:27 ` Ikjoon Jang
2020-12-11 1:53 ` [PATCH v2 0/3] Release allocated periodic bandwidth data from reset_bandwidth() Chunfeng Yun
2020-12-11 6:36 ` Ikjoon Jang
2020-12-14 3:24 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9H/ZVpHf2Owd6rj@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunfeng.yun@mediatek.com \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=tianping.fang@mediatek.com \
--cc=zhanyong.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).