From: Vinod Koul <vkoul@kernel.org>
To: Michael Trimarchi <michael@amarulasolutions.com>
Cc: "Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org,
linux-amarula@amarulasolutions.com
Subject: Re: [RFC PATCH 2/4] phy: rockchip: Add inno_is_valid_phy_mode
Date: Fri, 13 Jan 2023 23:28:12 +0530 [thread overview]
Message-ID: <Y8GbtA7+xHtBEpRs@matsya> (raw)
In-Reply-To: <20221002064540.2500257-3-michael@amarulasolutions.com>
On 02-10-22, 08:45, Michael Trimarchi wrote:
> The function is used to avoid to enable clock on the hardware
> if the mode requested is invalid
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> index 630e01b5c19b..644cf73cfd53 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c
> @@ -217,6 +217,20 @@ static void phy_update_bits(struct inno_dsidphy *inno,
> writel(tmp, inno->phy_base + reg);
> }
>
> +static int inno_is_valid_phy_mode(struct inno_dsidphy *inno)
> +{
> + switch (inno->mode) {
> + case PHY_MODE_MIPI_DPHY:
> + break;
> + case PHY_MODE_LVDS:
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + return 0;
> +};
> +
> static unsigned long inno_dsidphy_pll_calc_rate(struct inno_dsidphy *inno,
> unsigned long rate)
> {
> @@ -495,6 +509,11 @@ static void inno_dsidphy_lvds_mode_enable(struct inno_dsidphy *inno)
> static int inno_dsidphy_power_on(struct phy *phy)
> {
> struct inno_dsidphy *inno = phy_get_drvdata(phy);
> + int ret = 0;
this initialization is superfluous
> +
> + ret = inno_is_valid_phy_mode(inno);
> + if (ret)
> + return ret;
>
> clk_prepare_enable(inno->pclk_phy);
> clk_prepare_enable(inno->ref_clk);
> --
> 2.34.1
--
~Vinod
next prev parent reply other threads:[~2023-01-13 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 6:45 [RFC PATCH 0/4] Add RGB ttl connection on rockchip phy Michael Trimarchi
2022-10-02 6:45 ` [RFC PATCH 1/4] phy: add PHY_MODE_TTL Michael Trimarchi
2022-10-02 6:45 ` [RFC PATCH 2/4] phy: rockchip: Add inno_is_valid_phy_mode Michael Trimarchi
2023-01-13 17:58 ` Vinod Koul [this message]
2022-10-02 6:45 ` [RFC PATCH 3/4] phy: rockchip: Implement TTY phy mode Michael Trimarchi
2022-10-02 6:45 ` [RFC PATCH 4/4] drm/rockchip: rgb: Add dphy connection to rgb output Michael Trimarchi
2022-12-19 12:35 ` [RFC PATCH 0/4] Add RGB ttl connection on rockchip phy Michael Nazzareno Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8GbtA7+xHtBEpRs@matsya \
--to=vkoul@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kishon@ti.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).