From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>,
"Luca Ceresoli" <luca@lucaceresoli.net>
Subject: Re: [PATCH v7 1/7] i2c: add I2C Address Translator (ATR) support
Date: Fri, 20 Jan 2023 17:58:30 +0200 [thread overview]
Message-ID: <Y8q6JsDD7c0QCOq5@smile.fi.intel.com> (raw)
In-Reply-To: <31562353-0794-8ad4-d609-3c117dd28d46@ideasonboard.com>
On Thu, Jan 19, 2023 at 12:01:33PM +0200, Tomi Valkeinen wrote:
> On 18/01/2023 16:23, Andy Shevchenko wrote:
> > On Wed, Jan 18, 2023 at 02:40:25PM +0200, Tomi Valkeinen wrote:
...
> > > + /* Ensure we have enough room to save the original addresses */
> > > + if (unlikely(chan->orig_addrs_size < num)) {
> > > + u16 *new_buf;
> > > +
> > > + new_buf = kmalloc_array(num, sizeof(*new_buf), GFP_KERNEL);
> >
> > I remember that I asked why we don't use krealloc_array() here... Perhaps
> > that we don't need to copy the old mapping table? Can we put a short comment
> > to clarify this in the code?
>
> Yes, we don't care about the old data, we just require the buffer to be
> large enough.
>
> I'm not sure what kind of comment you want here. Isn't this a common idiom,
> where you have a buffer for temporary data, but you might need to resize at
> some point if you need a larger one?
Then why not krealloc_array()? That's the question I want to see the answer for
in the comments:
/* We don't care about old data, hence no realloc() */
> > > + if (!new_buf)
> > > + return -ENOMEM;
> > > +
> > > + kfree(chan->orig_addrs);
> > > + chan->orig_addrs = new_buf;
> > > + chan->orig_addrs_size = num;
> > > + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-20 15:58 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:40 [PATCH v7 0/7] i2c-atr and FPDLink Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 1/7] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2023-01-18 14:23 ` Andy Shevchenko
2023-01-18 17:17 ` Luca Ceresoli
2023-01-18 17:39 ` Andy Shevchenko
2023-01-19 8:21 ` Luca Ceresoli
2023-01-19 10:09 ` Tomi Valkeinen
2023-01-19 11:35 ` Luca Ceresoli
2023-01-19 12:22 ` Tomi Valkeinen
2023-01-19 13:00 ` Luca Ceresoli
2023-01-20 9:55 ` Laurent Pinchart
2023-01-20 13:58 ` Luca Ceresoli
2023-01-19 12:39 ` Tomi Valkeinen
2023-01-19 13:08 ` Luca Ceresoli
2023-01-19 10:01 ` Tomi Valkeinen
2023-01-20 15:58 ` Andy Shevchenko [this message]
2023-01-20 16:00 ` Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 2/7] dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 3/7] dt-bindings: media: add TI DS90UB953 " Tomi Valkeinen
2023-01-18 12:40 ` [PATCH v7 4/7] dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer Tomi Valkeinen
2023-01-19 23:24 ` Laurent Pinchart
2023-01-18 12:40 ` [PATCH v7 5/7] media: i2c: add DS90UB960 driver Tomi Valkeinen
2023-01-18 15:48 ` Andy Shevchenko
2023-01-19 16:27 ` Tomi Valkeinen
2023-01-19 23:19 ` Laurent Pinchart
2023-01-20 16:47 ` Andy Shevchenko
2023-01-25 11:15 ` Tomi Valkeinen
2023-01-25 12:10 ` Andy Shevchenko
2023-01-25 13:33 ` Tomi Valkeinen
2023-01-25 14:49 ` Andy Shevchenko
2023-01-25 15:14 ` Tomi Valkeinen
2023-01-25 15:27 ` Andy Shevchenko
2023-01-26 8:41 ` Tomi Valkeinen
2023-01-26 10:21 ` Andy Shevchenko
2023-01-26 10:51 ` Laurent Pinchart
2023-01-27 8:24 ` Tomi Valkeinen
2023-01-27 9:15 ` Andy Shevchenko
2023-02-08 15:10 ` Tomi Valkeinen
2023-02-09 10:54 ` Laurent Pinchart
2023-01-18 12:40 ` [PATCH v7 6/7] media: i2c: add DS90UB913 driver Tomi Valkeinen
2023-01-20 0:03 ` Laurent Pinchart
2023-01-20 7:04 ` Tomi Valkeinen
2023-01-20 9:06 ` Laurent Pinchart
2023-01-18 12:40 ` [PATCH v7 7/7] media: i2c: add DS90UB953 driver Tomi Valkeinen
2023-01-20 0:34 ` Laurent Pinchart
2023-01-20 8:13 ` Tomi Valkeinen
2023-01-20 9:23 ` Laurent Pinchart
2023-01-18 16:01 ` [PATCH v7 0/7] i2c-atr and FPDLink Andy Shevchenko
2023-01-18 17:28 ` Tomi Valkeinen
2023-01-18 17:43 ` Andy Shevchenko
2023-01-19 8:43 ` Luca Ceresoli
2023-01-19 12:40 ` Tomi Valkeinen
2023-01-19 13:19 ` Luca Ceresoli
2023-01-20 16:00 ` Andy Shevchenko
2023-01-20 16:17 ` Luca Ceresoli
2023-01-20 16:20 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8q6JsDD7c0QCOq5@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=luca@lucaceresoli.net \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).