From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: karthik alapati <mail@karthek.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix block comments alignment
Date: Tue, 9 Feb 2021 19:59:02 +0100 [thread overview]
Message-ID: <YCLbdtaTRk8dtsVA@kroah.com> (raw)
In-Reply-To: <YCLaHXD/sUKM5HZE@karthik-strix-linux.karthek.com>
On Wed, Feb 10, 2021 at 12:23:17AM +0530, karthik alapati wrote:
> fix checkpatch.pl warning for "block comments should align the * on each line"
>
> Signed-off-by: karthik alapati <mail@karthek.com>
> ---
> .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +++++++++---------
> 1 file changed, 102 insertions(+), 102 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index cf23414d7..003f954c2 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -20,16 +20,16 @@
> #define MAX_DOZE_WAITING_TIMES_9x 64
>
> /**
> -* Function: phy_CalculateBitShift
> -*
> -* OverView: Get shifted position of the BitMask
> -*
> -* Input:
> -* u32 BitMask,
> -*
> -* Output: none
> -* Return: u32 Return the shift bit bit position of the mask
> -*/
> + * Function: phy_CalculateBitShift
> + *
> + * OverView: Get shifted position of the BitMask
> + *
> + * Input:
> + * u32 BitMask,
> + *
> + * Output: none
> + * Return: u32 Return the shift bit bit position of the mask
> + */
These huge function comments are not normal kernel coding style anyway,
why not fix them up to use the correct style, don't paper over it and
keep this mess around any longer than it needs to be.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-09 21:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 18:53 [PATCH] staging: rtl8723bs: fix block comments alignment karthik alapati
2021-02-09 18:59 ` Greg Kroah-Hartman [this message]
[not found] ` <YCLd2286lLdO0BAE@karthik-strix-linux.karthek.com>
2021-02-09 19:17 ` karthek
2021-02-10 7:27 ` Dan Carpenter
2021-02-10 7:37 ` karthek
-- strict thread matches above, loose matches on Subject: below --
2021-02-07 14:16 karthek
2021-02-07 14:34 ` Greg Kroah-Hartman
[not found] ` <YB/9hS2S1oaCmuDq@karthik-strix-linux.karthek.com>
[not found] ` <YB//EZl0aeLk/y+E@kroah.com>
2021-02-07 15:11 ` karthek
2021-02-07 15:15 ` Greg Kroah-Hartman
2021-02-07 15:19 ` karthek
2021-02-07 15:21 ` Greg Kroah-Hartman
2021-02-07 15:24 ` karthek
2021-02-07 15:26 ` Greg Kroah-Hartman
2021-02-07 15:33 ` karthek
2021-02-09 16:20 ` karthek
2021-02-09 17:23 ` Greg Kroah-Hartman
2021-02-09 17:56 ` karthek
2021-02-09 18:49 ` Greg Kroah-Hartman
2021-02-09 18:52 ` karthek
2021-02-09 18:48 ` karthek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCLbdtaTRk8dtsVA@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@karthek.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).