From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Gokul Sriram Palanisamy <gokulsri@codeaurora.org>
Cc: sboyd@kernel.org, agross@kernel.org, david.brown@linaro.org,
devicetree@vger.kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
mark.rutland@arm.com, mturquette@baylibre.com, ohad@wizery.com,
robh+dt@kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH 2/3] remoteproc: qcom: wcss: populate driver data for IPQ6018
Date: Wed, 17 Mar 2021 21:10:48 -0500 [thread overview]
Message-ID: <YFK2qL+/50L7+LKV@builder.lan> (raw)
In-Reply-To: <1611940320-24830-3-git-send-email-gokulsri@codeaurora.org>
On Fri 29 Jan 11:11 CST 2021, Gokul Sriram Palanisamy wrote:
> Populate hardcoded param using driver data for IPQ6018 SoCs.
>
> Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org>
> ---
> drivers/remoteproc/qcom_q6v5_wcss.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
> index 7c64bfc..bc9531c 100644
> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
> @@ -965,7 +965,7 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *wcss)
> return 0;
> }
>
> -static int ipq8074_init_clock(struct q6v5_wcss *wcss)
> +static int ipq_init_clock(struct q6v5_wcss *wcss)
> {
> int ret;
>
> @@ -1172,7 +1172,7 @@ static int q6v5_wcss_remove(struct platform_device *pdev)
> }
>
> static const struct wcss_data wcss_ipq8074_res_init = {
> - .init_clock = ipq8074_init_clock,
> + .init_clock = ipq_init_clock,
> .q6_firmware_name = "IPQ8074/q6_fw.mdt",
> .m3_firmware_name = "IPQ8074/m3_fw.mdt",
> .crash_reason_smem = WCSS_CRASH_REASON,
> @@ -1185,6 +1185,20 @@ static const struct wcss_data wcss_ipq8074_res_init = {
> .need_mem_protection = true,
> };
>
> +static const struct wcss_data wcss_ipq6018_res_init = {
> + .init_clock = ipq_init_clock,
> + .q6_firmware_name = "IPQ6018/q6_fw.mdt",
> + .m3_firmware_name = "IPQ6018/m3_fw.mdt",
> + .crash_reason_smem = WCSS_CRASH_REASON,
> + .aon_reset_required = true,
> + .wcss_q6_reset_required = true,
> + .bcr_reset_required = false,
> + .ssr_name = "q6wcss",
> + .ops = &q6v5_wcss_ipq8074_ops,
> + .requires_force_stop = true,
> + .need_mem_protection = true,
> +};
> +
> static const struct wcss_data wcss_qcs404_res_init = {
> .init_clock = qcs404_init_clock,
> .init_regulator = qcs404_init_regulator,
> @@ -1203,6 +1217,7 @@ static const struct wcss_data wcss_qcs404_res_init = {
>
> static const struct of_device_id q6v5_wcss_of_match[] = {
> { .compatible = "qcom,ipq8074-wcss-pil", .data = &wcss_ipq8074_res_init },
> + { .compatible = "qcom,ipq6018-wcss-pil", .data = &wcss_ipq6018_res_init },
As you rebase on the reworked dependency, please sorted alphabetically
(i.e 6 < 8)
Regards,
Bjorn
> { .compatible = "qcom,qcs404-wcss-pil", .data = &wcss_qcs404_res_init },
> { },
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-03-18 2:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 17:11 [PATCH 0/3] remoteproc: qcom: q6v5-wcss: Add driver data for IPQ6018 Gokul Sriram Palanisamy
2021-01-29 17:11 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding " Gokul Sriram Palanisamy
2021-02-09 20:05 ` Rob Herring
2021-01-29 17:11 ` [PATCH 2/3] remoteproc: qcom: wcss: populate driver data " Gokul Sriram Palanisamy
2021-03-18 2:10 ` Bjorn Andersson [this message]
2021-01-29 17:12 ` [PATCH 3/3] arm64: dts: ipq6018: Update WCSS PIL driver compatible Gokul Sriram Palanisamy
-- strict thread matches above, loose matches on Subject: below --
2021-01-29 17:09 [PATCH 0/3] remoteproc: qcom: q6v5-wcss: Add driver data for IPQ6018 Gokul Sriram Palanisamy
2021-01-29 17:09 ` [PATCH 2/3] remoteproc: qcom: wcss: populate " Gokul Sriram Palanisamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFK2qL+/50L7+LKV@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gokulsri@codeaurora.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).