From: Eric Biggers <ebiggers@kernel.org>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH 07/18] f2fs: convert to miscattr
Date: Mon, 22 Mar 2021 17:28:20 -0700 [thread overview]
Message-ID: <YFk2JPmc7X7GFXni@gmail.com> (raw)
In-Reply-To: <20210203124112.1182614-8-mszeredi@redhat.com>
On Wed, Feb 03, 2021 at 01:41:01PM +0100, Miklos Szeredi wrote:
> @@ -3071,123 +3012,54 @@ static int f2fs_ioc_setproject(struct file *filp, __u32 projid)
> }
> #endif
>
> -/* FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR support */
> -
> -/*
> - * To make a new on-disk f2fs i_flag gettable via FS_IOC_FSGETXATTR and settable
> - * via FS_IOC_FSSETXATTR, add an entry for it to f2fs_xflags_map[], and add its
> - * FS_XFLAG_* equivalent to F2FS_SUPPORTED_XFLAGS.
> - */
> -
> -static const struct {
> - u32 iflag;
> - u32 xflag;
> -} f2fs_xflags_map[] = {
> - { F2FS_SYNC_FL, FS_XFLAG_SYNC },
> - { F2FS_IMMUTABLE_FL, FS_XFLAG_IMMUTABLE },
> - { F2FS_APPEND_FL, FS_XFLAG_APPEND },
> - { F2FS_NODUMP_FL, FS_XFLAG_NODUMP },
> - { F2FS_NOATIME_FL, FS_XFLAG_NOATIME },
> - { F2FS_PROJINHERIT_FL, FS_XFLAG_PROJINHERIT },
> -};
There's another comment just above which talks about FS_IOC_GETFLAGS and
FS_IOC_SETFLAGS:
/* FS_IOC_GETFLAGS and FS_IOC_SETFLAGS support */
/*
* To make a new on-disk f2fs i_flag gettable via FS_IOC_GETFLAGS, add an entry
* for it to f2fs_fsflags_map[], and add its FS_*_FL equivalent to
* F2FS_GETTABLE_FS_FL. To also make it settable via FS_IOC_SETFLAGS, also add
* its FS_*_FL equivalent to F2FS_SETTABLE_FS_FL.
*/
This patch seems to make that outdated, since now both FS_IOC_[GS]ETFLAGS and
FS_IOC_[GS]ETFSXATTR are handled together.
Can you please update the comment to properly describe what's going on?
- Eric
next prev parent reply other threads:[~2021-03-23 0:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 12:40 [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR Miklos Szeredi
2021-02-03 12:40 ` [PATCH 01/18] vfs: add miscattr ops Miklos Szeredi
2021-02-03 15:04 ` Jan Kara
2021-02-03 15:21 ` Miklos Szeredi
2021-03-23 0:23 ` Eric Biggers
2021-03-25 14:52 ` Miklos Szeredi
2021-03-25 15:17 ` Al Viro
2021-02-03 12:40 ` [PATCH 02/18] ecryptfs: stack " Miklos Szeredi
2021-02-03 12:40 ` [PATCH 03/18] ovl: stack miscattr Miklos Szeredi
2021-02-04 23:42 ` Vivek Goyal
2021-02-05 15:25 ` Miklos Szeredi
2021-02-05 15:28 ` Miklos Szeredi
2021-02-03 12:40 ` [PATCH 04/18] btrfs: convert to miscattr Miklos Szeredi
2021-02-03 12:40 ` [PATCH 05/18] ext2: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 06/18] ext4: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 07/18] f2fs: " Miklos Szeredi
2021-03-23 0:28 ` Eric Biggers [this message]
2021-02-03 12:41 ` [PATCH 08/18] gfs2: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 09/18] orangefs: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 10/18] xfs: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 11/18] efivars: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 12/18] hfsplus: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 13/18] jfs: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 14/18] nilfs2: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 15/18] ocfs2: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 16/18] reiserfs: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 17/18] ubifs: " Miklos Szeredi
2021-02-03 12:41 ` [PATCH 18/18] vfs: remove unused ioctl helpers Miklos Szeredi
2021-02-03 13:05 ` [PATCH 00/18] new API for FS_IOC_[GS]ETFLAGS/FS_IOC_FS[GS]ETXATTR Matthew Wilcox
2021-02-03 13:13 ` Miklos Szeredi
2021-02-03 13:58 ` Matthew Wilcox
2021-02-03 14:13 ` Miklos Szeredi
2021-02-03 14:28 ` Matthew Wilcox
2021-02-03 14:38 ` Miklos Szeredi
2021-02-03 14:56 ` Matthew Wilcox
2021-02-03 15:03 ` Miklos Szeredi
2021-02-08 2:00 ` Dave Chinner
2021-02-08 8:25 ` Miklos Szeredi
2021-02-08 14:02 ` Matthew Wilcox
2021-02-08 14:52 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFk2JPmc7X7GFXni@gmail.com \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).