From: Anirudh Rayabharam <mail@anirudhrb.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mike Isely <isely@pobox.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
gregkh@linuxfoundation.org,
syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: pvrusb2: fix warning in pvr2_i2c_core_done
Date: Wed, 7 Apr 2021 21:55:25 +0530 [thread overview]
Message-ID: <YG3c9eWJvHtnfXsf@anirudhrb.com> (raw)
In-Reply-To: <b81e4612-dde3-d6e5-e647-b61c7c3501da@xs4all.nl>
On Tue, Apr 06, 2021 at 11:38:25AM +0200, Hans Verkuil wrote:
> On 01/04/2021 14:33, Anirudh Rayabharam wrote:
> > syzbot has reported the following warning in pvr2_i2c_done:
> >
> > sysfs group 'power' not found for kobject '1-0043'
> >
> > When the device is disconnected (pvr_hdw_disconnect), the i2c adapter is
> > not unregistered along with the USB and vl42 teardown. As part of the
>
> vl42 -> v4l2
>
> > USB device disconnect, the sysfs files of the subdevices are also
> > deleted. So, by the time pvr_i2c_core_done is called by
> > pvr_context_destroy, the sysfs files have been deleted.
> >
> > To fix this, unregister the i2c adapter too in pvr_hdw_disconnect. Make
> > the device deregistration code shared by calling pvr_hdw_disconnect from
> > pvr2_hdw_destory.
>
> destory -> destroy
>
> >
> > Reported-and-tested-by: syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com
> > Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> > ---
> > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> > index f4a727918e35..791227787ff5 100644
> > --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> > +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> > @@ -2676,9 +2676,7 @@ void pvr2_hdw_destroy(struct pvr2_hdw *hdw)
> > pvr2_stream_destroy(hdw->vid_stream);
> > hdw->vid_stream = NULL;
> > }
> > - pvr2_i2c_core_done(hdw);
> > - v4l2_device_unregister(&hdw->v4l2_dev);
>
> I think this should still remain since pvr2_hdw_disconnect() doesn't call
> v4l2_device_unregister().
>
> Can you test that with syzbot?
Sent v2 with this change. Tested it with syzbot and didn't find any
problems.
Thanks.
- Anirudh.
prev parent reply other threads:[~2021-04-07 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:33 [PATCH] media: pvrusb2: fix warning in pvr2_i2c_core_done Anirudh Rayabharam
2021-04-01 20:58 ` Greg KH
2021-04-06 9:38 ` Hans Verkuil
2021-04-06 17:00 ` Anirudh Rayabharam
2021-04-07 16:25 ` Anirudh Rayabharam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG3c9eWJvHtnfXsf@anirudhrb.com \
--to=mail@anirudhrb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=isely@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).