From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Jérôme de Bretagne" <jerome.debretagne@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"open list" <linux-kernel@vger.kernel.org>,
"Jani Nikula" <jani.nikula@intel.com>,
stable@vger.kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>,
"Sean Paul" <sean@poorly.run>
Subject: Re: [PATCH 1/2] drm/dp: Handle zeroed port counts in drm_dp_read_downstream_info()
Date: Mon, 3 May 2021 06:13:08 +0300 [thread overview]
Message-ID: <YI9qRPkSDGrLAaFg@intel.com> (raw)
In-Reply-To: <20210430223428.10514-1-lyude@redhat.com>
On Fri, Apr 30, 2021 at 06:34:27PM -0400, Lyude Paul wrote:
> While the DP specification isn't entirely clear on if this should be
> allowed or not, some branch devices report having downstream ports present
> while also reporting a downstream port count of 0. So to avoid breaking
> those devices, we need to handle this in drm_dp_read_downstream_info().
>
> So, to do this we assume there's no downstream port info when the
> downstream port count is 0.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Tested-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
> Bugzilla: https://gitlab.freedesktop.org/drm/intel/-/issues/3416
> Fixes: 3d3721ccb18a ("drm/i915/dp: Extract drm_dp_read_downstream_info()")
> Cc: <stable@vger.kernel.org> # v5.10+
> ---
> drivers/gpu/drm/drm_dp_helper.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index cb56d74e9d38..27c8c5bdf7d9 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -682,7 +682,14 @@ int drm_dp_read_downstream_info(struct drm_dp_aux *aux,
> !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT))
> return 0;
>
> + /* Some branches advertise having 0 downstream ports, despite also advertising they have a
> + * downstream port present. The DP spec isn't clear on if this is allowed or not, but since
> + * some branches do it we need to handle it regardless.
> + */
> len = drm_dp_downstream_port_count(dpcd);
> + if (!len)
> + return 0;
> +
Seems sane enough.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> if (dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DETAILED_CAP_INFO_AVAILABLE)
> len *= 4;
>
> --
> 2.30.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2021-05-03 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 22:34 [PATCH 1/2] drm/dp: Handle zeroed port counts in drm_dp_read_downstream_info() Lyude Paul
2021-04-30 22:34 ` [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() " Lyude Paul
2021-05-03 3:06 ` [Intel-gfx] " Ville Syrjälä
2021-05-07 21:28 ` Lyude Paul
2021-05-03 3:13 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI9qRPkSDGrLAaFg@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jerome.debretagne@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=sean@poorly.run \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).