From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56594C433B4 for ; Mon, 26 Apr 2021 17:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 111A161026 for ; Mon, 26 Apr 2021 17:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235195AbhDZRIx (ORCPT ); Mon, 26 Apr 2021 13:08:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:53122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234767AbhDZRIt (ORCPT ); Mon, 26 Apr 2021 13:08:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42BC761026; Mon, 26 Apr 2021 17:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619456887; bh=k+DTG1EcAl57VnUN+ld4qn4IfenVpN4Jh5hBLU6qyic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aLvmQC0Q5YA72/S6fkEU4498Ux0pvSnaP1mPSjVblayMVrP52tWYEJwqXvXop9sa8 2hIdvsNx6pdy8pO9BgO26QRY1aW+xL++d0KtBhDK2kOQcBR5QfZk0vTa0EeASdyKub bmF0Ok17ijuc6HZw8ZbEL4+PpJJuekjjyq9lQOm0= Date: Mon, 26 Apr 2021 19:08:05 +0200 From: Greg Kroah-Hartman To: Hans de Goede Cc: linux-kernel@vger.kernel.org, Wenwen Wang Subject: Re: [PATCH 186/190] Revert "virt: vbox: Only copy_from_user the request-header once" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-187-gregkh@linuxfoundation.org> <68067532-56e5-c135-7a7e-0743c8e7b2a0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 06:59:58PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 21, 2021 at 06:51:24PM +0200, Hans de Goede wrote: > > Hi Greg, > > > > On 4/21/21 3:01 PM, Greg Kroah-Hartman wrote: > > > This reverts commit bd23a7269834dc7c1f93e83535d16ebc44b75eba. > > > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > > faith" to try to test the kernel community's ability to review "known > > > malicious" changes. The result of these submissions can be found in a > > > paper published at the 42nd IEEE Symposium on Security and Privacy > > > entitled, "Open Source Insecurity: Stealthily Introducing > > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > > > Because of this, all submissions from this group must be reverted from > > > the kernel tree and will need to be re-reviewed again to determine if > > > they actually are a valid fix. Until that work is complete, remove this > > > change to ensure that no problems are being introduced into the > > > codebase. > > > > > > Cc: Wenwen Wang > > > Cc: Hans de Goede > > > Cc: Greg Kroah-Hartman > > > Signed-off-by: Greg Kroah-Hartman > > > > Ugh what a mess (the whole umn.edu thing). > > > > I still remember reviewing this patch during its original submission > > and I've reviewed it again this morning when you just send it out. > > > > And now after letting it sit for a bit I've reviewed it a third time > > and it seems to do what it says on the label / in the original commit > > msg; and if fixes a real, potentially security, issue. > > > > I'm not sure what the process is for "good" patches in the set > > which you are reverting. I would prefer for this patch to be dropped > > from the set of reveert. But I can also submit a revert of the revert(?) > > once this set of reverts has been merged. > > If you have reviewed it, and think it should stay, I will drop the > revert from my patch series. Other maintainers/reviewers have asked the > same thing for their patches, which is fine. > > Anything that I do end up reverting, that was not reviewed, will be > again reviewed by me and others to determine if it is "safe" to come > back in at a later point in time. > > So thanks for the review, I'll drop this one. Now dropped, thanks for the review. greg k-h