From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFBBC433ED for ; Tue, 27 Apr 2021 13:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F27B613DE for ; Tue, 27 Apr 2021 13:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236354AbhD0Nlp (ORCPT ); Tue, 27 Apr 2021 09:41:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:37888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235652AbhD0Nln (ORCPT ); Tue, 27 Apr 2021 09:41:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC199613D1; Tue, 27 Apr 2021 13:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619530860; bh=3OwuNzi/3p8g5rvYpkJeU0dXgNB6dHXSteBlKa9/Mzw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g7SZfOv00m648lDCgS+FKgn+gPJsf1uHcbY0vgRcWS8ISYYlyl1nonS+yoM14t2MX aVdFOS2A8UH8luFfRRc5uhX1Xl7IlAI9QafWgDHSQHNpIgxYC4SJjFFHbD5mL6bvWk VvQFeyaYG58Mx5Su8pAeu+nF7HJgNmSSMowaQM3s= Date: Tue, 27 Apr 2021 15:40:57 +0200 From: Greg Kroah-Hartman To: "Deucher, Alexander" Cc: "linux-kernel@vger.kernel.org" , "Quan, Evan" , Aditya Pakki Subject: Re: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-23-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 04:08:05PM +0000, Deucher, Alexander wrote: > [AMD Public Use] > > > -----Original Message----- > > From: Greg Kroah-Hartman > > Sent: Wednesday, April 21, 2021 8:58 AM > > To: linux-kernel@vger.kernel.org > > Cc: Greg Kroah-Hartman ; Quan, Evan > > ; Aditya Pakki ; Deucher, > > Alexander > > Subject: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks > > caused by pm_runtime_get_sync" > > > > This reverts commit 9fb10671011143d15b6b40d6d5fa9c52c57e9d63. > > > > Commits from @umn.edu addresses have been found to be submitted in > > "bad faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a paper > > published at the 42nd IEEE Symposium on Security and Privacy entitled, > > "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite > > Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu > > (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from the > > kernel tree and will need to be re-reviewed again to determine if they > > actually are a valid fix. Until that work is complete, remove this change to > > ensure that no problems are being introduced into the codebase. > > > > Cc: Evan Quan > > Cc: Aditya Pakki > > Cc: Alex Deucher > > Signed-off-by: Greg Kroah-Hartman > > AFAICT, this patch is correct or at least does no harm. Handling of pm_runtime_get_sync() errors in the kernel seems to be inconsistent at best. Thanks for the review, I'll drop this revert from the tree. greg k-h