linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Jin, Yao" <yao.jin@linux.intel.com>,
	jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v6 00/26] perf tool: AlderLake hybrid support series 1
Date: Wed, 28 Apr 2021 10:44:58 -0300	[thread overview]
Message-ID: <YIlm2k6ok3Gey3FU@kernel.org> (raw)
In-Reply-To: <YIkOn9ZaTv87Kmjw@krava>

Em Wed, Apr 28, 2021 at 09:28:31AM +0200, Jiri Olsa escreveu:
> On Wed, Apr 28, 2021 at 09:57:40AM +0800, Jin, Yao wrote:
> 
> SNIP
> 
> > > >           1.003959036 seconds time elapsed
> > > > 
> > > > Note that, since the whole patchset for AlderLake hybrid support is very
> > > > large (40+ patches). For simplicity, it's splitted into several patch
> > > > series.
> > > > 
> > > > The patch series 1 only supports the basic functionality. The advanced
> > > > supports for perf-c2c/perf-mem/topdown/metrics/topology header and others
> > > > will be added in follow-up patch series.
> > > > 
> > > > The perf tool codes can also be found at:
> > > > https://github.com/yaoj/perf.git
> > > 
> > > hi,
> > > did you update the branch for v6? I think I can't see
> > > the new update there
> > > 
> > > thanks,
> > > jirka
> > > 
> > 
> > I just pushed the latest updates to https://github.com/yaoj/perf.git. Sorry it's getting late.
> > 
> > Actually it's Arnaldo's tmp.perf/core branch. Arnaldo has applied the patch
> > series on tmp.perf/core and with an update on "[PATCH v6 01/26] tools
> > headers uapi: Update tools's copy of
> >  linux/perf_event.h".
> 
> np, I used Arnaldo's branch for review
> 
> > 
> > If there are more comments which need to be addressed, we will start from tmp.perf/core for v7.
> > 
> > Thanks
> > Jin Yao
> > 
> > > > 
> > > > Note that, this patch series is based on tmp.perf/core branch.
> > > > 
> > > > v6:
> > > > ---
> > > > - Rebase to tmp.perf/core branch.
> > > > 
> > > > - A minor update in v6 patch series.
> > > > 
> > > >    In '[PATCH v6 18/26] perf tests: Add hybrid cases for 'Parse event
> > > >    definition strings' test', we add a test case for cache events with
> > > >    pmu prefix.
> > > > 
> > > >    No other updates.
> 
> I can't test the functionality, but apart from that all seems fine
> and non-hybrid stuff keeps working ;-)
> 
> Reviewed-by: Jiri Olsa <jolsa@kernel.org>

Thanks, added it to the series.

- Arnaldo

      parent reply	other threads:[~2021-04-28 13:45 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  7:01 [PATCH v6 00/26] perf tool: AlderLake hybrid support series 1 Jin Yao
2021-04-27  7:01 ` [PATCH v6 01/26] tools headers uapi: Update tools's copy of linux/perf_event.h Jin Yao
2021-04-27 19:24   ` Arnaldo Carvalho de Melo
2021-04-28  1:18     ` Jin, Yao
2021-04-27  7:01 ` [PATCH v6 02/26] perf jevents: Support unit value "cpu_core" and "cpu_atom" Jin Yao
2021-04-27  7:01 ` [PATCH v6 03/26] perf pmu: Simplify arguments of __perf_pmu__new_alias Jin Yao
2021-04-27  7:01 ` [PATCH v6 04/26] perf pmu: Save pmu name Jin Yao
2021-04-27  7:01 ` [PATCH v6 05/26] perf pmu: Save detected hybrid pmus to a global pmu list Jin Yao
2021-04-27  7:01 ` [PATCH v6 06/26] perf pmu: Add hybrid helper functions Jin Yao
2021-04-27  7:01 ` [PATCH v6 07/26] perf stat: Uniquify hybrid event name Jin Yao
2021-04-27  7:01 ` [PATCH v6 08/26] perf parse-events: Create two hybrid hardware events Jin Yao
2021-04-27  7:01 ` [PATCH v6 09/26] perf parse-events: Create two hybrid cache events Jin Yao
2021-04-27  7:01 ` [PATCH v6 10/26] perf parse-events: Create two hybrid raw events Jin Yao
2021-04-27  7:01 ` [PATCH v6 11/26] perf parse-events: Compare with hybrid pmu name Jin Yao
2021-04-27  7:01 ` [PATCH v6 12/26] perf parse-events: Support event inside hybrid pmu Jin Yao
2021-04-27  7:01 ` [PATCH v6 13/26] perf record: Create two hybrid 'cycles' events by default Jin Yao
2021-04-27  7:01 ` [PATCH v6 14/26] perf stat: Add default hybrid events Jin Yao
2021-04-27  7:01 ` [PATCH v6 15/26] perf stat: Filter out unmatched aggregation for hybrid event Jin Yao
2021-04-27  7:01 ` [PATCH v6 16/26] perf stat: Warn group events from different hybrid PMU Jin Yao
2021-04-27  7:01 ` [PATCH v6 17/26] perf record: Uniquify hybrid event name Jin Yao
2021-04-27  7:01 ` [PATCH v6 18/26] perf tests: Add hybrid cases for 'Parse event definition strings' test Jin Yao
2021-04-27  7:01 ` [PATCH v6 19/26] perf tests: Add hybrid cases for 'Roundtrip evsel->name' test Jin Yao
2021-04-27  7:01 ` [PATCH v6 20/26] perf tests: Skip 'Setup struct perf_event_attr' test for hybrid Jin Yao
2021-04-27  7:01 ` [PATCH v6 21/26] perf tests: Support 'Track with sched_switch' " Jin Yao
2021-04-27  7:01 ` [PATCH v6 22/26] perf tests: Support 'Parse and process metrics' " Jin Yao
2021-04-27  7:01 ` [PATCH v6 23/26] perf tests: Support 'Session topology' " Jin Yao
2021-04-27  7:01 ` [PATCH v6 24/26] perf tests: Support 'Convert perf time to TSC' " Jin Yao
2021-04-27  7:01 ` [PATCH v6 25/26] perf tests: Skip 'perf stat metrics (shadow stat) test' " Jin Yao
2021-04-27  7:01 ` [PATCH v6 26/26] perf Documentation: Document intel-hybrid support Jin Yao
2021-04-27 12:50 ` [PATCH v6 00/26] perf tool: AlderLake hybrid support series 1 Jiri Olsa
2021-04-27 13:14   ` Arnaldo Carvalho de Melo
2021-04-28  1:57   ` Jin, Yao
2021-04-28  7:28     ` Jiri Olsa
2021-04-28  8:01       ` Jin, Yao
2021-04-28 13:44       ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIlm2k6ok3Gey3FU@kernel.org \
    --to=acme@kernel.org \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).