From: Mike Rapoport <rppt@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [RFT PATCH] MIPS: Octeon: drop dependency on CONFIG_HOLES_IN_ZONE
Date: Fri, 30 Apr 2021 18:11:44 +0300 [thread overview]
Message-ID: <YIweMMiWyMXTsijo@kernel.org> (raw)
In-Reply-To: <20210430104256.GA6148@alpha.franken.de>
On Fri, Apr 30, 2021 at 12:42:56PM +0200, Thomas Bogendoerfer wrote:
> On Fri, Apr 30, 2021 at 12:35:32PM +0300, Mike Rapoport wrote:
> > Hi Thomas,
> >
> > On Thu, Apr 29, 2021 at 11:06:32PM +0200, Thomas Bogendoerfer wrote:
> > > On Sun, Apr 18, 2021 at 12:35:12PM +0300, Mike Rapoport wrote:
> > > > I'd really appreciate if somebody with access to an Octeon system could
> > > > test this patch.
> > >
> > > Tested on an Ubiquiti edgerouter 12. Works with problem and I haven't
> > > even seen a change in memory output.
> >
> > Is "works with problem" a misprint or something went wrong?
>
> that should have been "without problem".
Thanks for the clarification :)
> All good in my test, but that was more or less booting and checking
> memory log messages.
Well, this is way better than build testing I did. The commit 465aaed0030b
("MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE") that added
CONFIG_HOLES_IN_ZONE for Octeons talked about crashes at boot time, so
boot testing seems appropriate.
The only concern, is peculiar memory configuration Octeon may have with
Linux and non-Linux "partitions" that will be different on different
systems, but nevertheless I think the generic mm nowadays is robust enough
to cope with those without CONFIG_HOLES_IN_ZONE.
I presumed the patch would go via MIPS tree, so it's you call Thomas.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-04-30 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 9:35 [RFT PATCH] MIPS: Octeon: drop dependency on CONFIG_HOLES_IN_ZONE Mike Rapoport
2021-04-29 21:06 ` Thomas Bogendoerfer
2021-04-30 9:35 ` Mike Rapoport
2021-04-30 10:42 ` Thomas Bogendoerfer
2021-04-30 15:11 ` Mike Rapoport [this message]
2021-05-11 20:40 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIweMMiWyMXTsijo@kernel.org \
--to=rppt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).