From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
outreachy-kernel@googlegroups.com,
David Kershner <david.kershner@unisys.com>,
sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Outreachy kernel] Re: [PATCH v7] staging: unisys: visorhba: Convert module from IDR to XArray
Date: Tue, 4 May 2021 17:46:29 +0200 [thread overview]
Message-ID: <YJFsVTA/DTLvfWQG@kroah.com> (raw)
In-Reply-To: <810075373.q0sU067TuV@linux.local>
On Tue, May 04, 2021 at 04:38:11PM +0200, Fabio M. De Francesco wrote:
>
> As far as (1) and (2) are regarded, I've been told that when one modifies code
> she/he should not diverge from the style of the subsystem/driver maintainer/
> author. If you look at visorhba_main.c, you'll find a lot of unnecessary
> 'else' and 'if (success)'...
>
> So what are the general rules one should follow when changing (trivial) Linux
> code? Please note that my question has no other (hidden) purposes than
> learning to work properly with the Linux community and to reduce the
> unnecessary noise consequential to submitting a high number of patch versions.
"trivial" changes should only be done in subsystems that welcome it.
drivers/staging/ welcomes it, anything other than that, you need to ask
the maintainer.
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-04 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 13:32 [PATCH v7] staging: unisys: visorhba: Convert module from IDR to XArray Fabio M. De Francesco
2021-05-04 13:42 ` Matthew Wilcox
2021-05-04 13:58 ` Fabio M. De Francesco
2021-05-04 14:01 ` [Outreachy kernel] " Matthew Wilcox
2021-05-04 14:38 ` Fabio M. De Francesco
2021-05-04 15:46 ` Greg Kroah-Hartman [this message]
2021-05-04 13:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJFsVTA/DTLvfWQG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=david.kershner@unisys.com \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
--cc=sparmaintainer@unisys.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).