From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: James Feeney <james@nurealm.net>,
linux-smp@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
lkml <linux-kernel@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
x86-ml <x86@kernel.org>
Subject: Re: [PATCH] x86/thermal: Fix LVT thermal setup for SMI delivery mode
Date: Thu, 27 May 2021 13:56:59 +0200 [thread overview]
Message-ID: <YK+JC9qjkEuz/aaz@zn.tnic> (raw)
In-Reply-To: <87h7io8kh5.ffs@nanos.tec.linutronix.de>
On Thu, May 27, 2021 at 01:49:42PM +0200, Thomas Gleixner wrote:
> That works, but TBH, it's a hack....
Yeah, it restores to the previous behavior.
> What I really fail to understand is how disabling that LVT entry makes
> the machine lock up.
The observation is is that on James' box, *sometimes* - not always - it
would softlockup on CPU0 without this early LVT thermal read.
I can try to reproduce on the box I have here, lemme see...
> Also if disabling this entry is causing the BIOS/SMM gunk to go south, then
> disabling CONFIG_X86_THERMAL_VECTOR should have the same effect.
>
> Which made me look at other places like lapic_suspend/resume which does
> the save/restore Kconfig conditional as well.
The fact that it doesn't reproduce always shows that there's something
else at play too. As I said in the commit message: "Those soft lockups
are not 100% reproducible and the reason for that can only be speculated
as no one tells you what SMM does."
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-05-27 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8a9599b2-f4fe-af9b-90f5-af39c315ec2f@nurealm.net>
2021-05-17 8:32 ` linux 5.12 - fails to boot - soft lockup - CPU#0 stuck for 23s! - RIP smp_call_function_single Borislav Petkov
2021-05-19 3:58 ` James Feeney
2021-05-19 11:12 ` Borislav Petkov
2021-05-19 20:03 ` James Feeney
2021-05-19 21:18 ` Borislav Petkov
2021-05-20 3:12 ` James Feeney
2021-05-20 9:21 ` Borislav Petkov
2021-05-21 22:11 ` James Feeney
2021-05-22 9:06 ` Borislav Petkov
2021-05-22 23:28 ` James Feeney
2021-05-23 17:05 ` Borislav Petkov
2021-05-23 23:02 ` James Feeney
2021-05-24 7:51 ` Borislav Petkov
2021-05-25 4:02 ` James Feeney
2021-05-27 10:31 ` [PATCH] x86/thermal: Fix LVT thermal setup for SMI delivery mode Borislav Petkov
2021-05-27 11:49 ` Thomas Gleixner
2021-05-27 11:56 ` Borislav Petkov [this message]
2021-05-27 18:54 ` Borislav Petkov
2021-05-28 8:23 ` Thomas Gleixner
2021-05-28 11:19 ` Borislav Petkov
2021-05-31 18:26 ` James Feeney
2021-05-27 18:09 ` Srinivas Pandruvada
2021-05-27 19:01 ` Borislav Petkov
2021-05-27 20:28 ` Srinivas Pandruvada
2021-05-28 7:05 ` James Feeney
2021-05-31 21:46 ` [tip: x86/urgent] " tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK+JC9qjkEuz/aaz@zn.tnic \
--to=bp@alien8.de \
--cc=axboe@kernel.dk \
--cc=james@nurealm.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-smp@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).