From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Elliot Berman <eberman@codeaurora.org>,
Sebastian Reichel <sre@kernel.org>, Todd Kjos <tkjos@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Trilok Soni <tsoni@codeaurora.org>,
rananta@codeaurora.org, open list <linux-kernel@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/2] reboot: Export reboot_mode
Date: Mon, 24 May 2021 22:32:50 -0500 [thread overview]
Message-ID: <YKxv4h8ebMQlNR37@yoga> (raw)
In-Reply-To: <CAF2Aj3jYtL_42h_4W5zA8uz9e-QVquja70nARSRD4vbECVjxKw@mail.gmail.com>
On Mon 24 May 07:09 CDT 2021, Lee Jones wrote:
> On Fri, 8 Nov 2019 at 23:41, Elliot Berman <eberman@codeaurora.org> wrote:
>
> > Export reboot_mode to support kernel modules wishing to modify reboot_mode.
> >
> > Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> > ---
> > kernel/reboot.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Reviewed by Bjorn and GregKH, but never merged.
>
> I guess all the parties are still solving this downstream.
>
> Andrew, is this still something you'd consider?
>
Seems more reasonable that it would go together with patch 2, which
Sebastian pointed out doesn't build.
Regards,
Bjorn
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index c4d472b..b1fbc22 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -32,7 +32,9 @@ EXPORT_SYMBOL(cad_pid);
> > #define DEFAULT_REBOOT_MODE
> > #endif
> > enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
> > +EXPORT_SYMBOL_GPL(reboot_mode);
> > enum reboot_mode panic_reboot_mode = REBOOT_UNDEFINED;
> > +EXPORT_SYMBOL_GPL(panic_reboot_mode);
> >
> > /*
> > * This variable is used privately to keep track of whether or not
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
> >
>
> --
> Lee Jones [?????????]
> Linaro Services Senior Technical Lead
> Linaro.org ??? Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-05-25 3:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 23:40 [PATCH v2 0/2] Support reboot power-off driver as module Elliot Berman
2019-11-08 23:40 ` [PATCH v2 1/2] reboot: Export reboot_mode Elliot Berman
2019-11-09 0:18 ` Bjorn Andersson
2019-11-09 8:38 ` Greg KH
[not found] ` <CAF2Aj3jYtL_42h_4W5zA8uz9e-QVquja70nARSRD4vbECVjxKw@mail.gmail.com>
2021-05-24 12:34 ` Greg Kroah-Hartman
2021-05-25 3:32 ` Bjorn Andersson [this message]
2019-11-08 23:40 ` [PATCH v2 2/2] power: reset: Enable tristate on restart power-off driver Elliot Berman
2019-12-19 0:08 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKxv4h8ebMQlNR37@yoga \
--to=bjorn.andersson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=eberman@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rananta@codeaurora.org \
--cc=sre@kernel.org \
--cc=tkjos@google.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).