From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDC4C47082 for ; Thu, 3 Jun 2021 18:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B2D7613BA for ; Thu, 3 Jun 2021 18:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbhFCSn1 (ORCPT ); Thu, 3 Jun 2021 14:43:27 -0400 Received: from mail.skyhub.de ([5.9.137.197]:45860 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhFCSn0 (ORCPT ); Thu, 3 Jun 2021 14:43:26 -0400 Received: from zn.tnic (p200300ec2f13850043af4c4d530a3258.dip0.t-ipconnect.de [IPv6:2003:ec:2f13:8500:43af:4c4d:530a:3258]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CD6D71EC04A6; Thu, 3 Jun 2021 20:41:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622745700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=psd+ZC8Co6XkZKgFq1VAPYa0k/9qp4aEkZyphaqsnvk=; b=PquDu7gfhoilzg0av43yBAR9Bl/foF8OonwQEIidmP7ibOdlCb8NsTAgDoJXfaA36xJ9jv O/+8gvcM88eeQwaUGnomw1XPrwQqOeCA933ygZGNnLLOCt003HqEvVTiuIfKpJ3hk5XYc9 gIKLKqqQC2gNq5nBg8a2Ubc/2csR7XM= Date: Thu, 3 Jun 2021 20:41:40 +0200 From: Borislav Petkov To: "Kuppuswamy, Sathyanarayanan" Cc: Peter Zijlstra , Andy Lutomirski , Dave Hansen , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org, Tom Lendacky Subject: Re: [RFC v2-fix-v2 1/1] x86: Introduce generic protected guest abstraction Message-ID: References: <20210527042356.3983284-2-sathyanarayanan.kuppuswamy@linux.intel.com> <20210601211417.2177598-1-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sathya, please trim your mails when you reply, like I've done in this reply. Thx. On Thu, Jun 03, 2021 at 11:33:53AM -0700, Kuppuswamy, Sathyanarayanan wrote: > I assume this file will get compiled for both SEV and SME cases. Yap. > Since you are checking for AMD vendor ID, why not use amd_protected_guest_has()? Because, as Sean already told you, we should either stick to the technologies: TDX or SEV or to the vendors: Intel or AMD - but not either or. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette