From: Ido Schimmel <idosch@idosch.org>
To: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Cc: jiri@nvidia.com, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vadym Kochan <vadym.kochan@plvision.eu>
Subject: Re: [PATCH net-next] drivers: net: netdevsim: fix devlink_trap selftests failing
Date: Thu, 17 Jun 2021 09:39:43 +0300 [thread overview]
Message-ID: <YMruL84N3A3yq1qy@shredder> (raw)
In-Reply-To: <20210616183405.3715-1-oleksandr.mazur@plvision.eu>
On Wed, Jun 16, 2021 at 09:34:05PM +0300, Oleksandr Mazur wrote:
You need to add a proper commit message here
> Fixes: a7b3527a43fe ("drivers: net: netdevsim: add devlink trap_drop_counter_get implementation")
>
No blank line between Fixes and SoB
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
> ---
> Test-results:
> selftests: drivers/net/netdevsim: devlink_trap.sh
> TEST: Initialization [ OK ]
> TEST: Trap action [ OK ]
> TEST: Trap metadata [ OK ]
> TEST: Non-existing trap [ OK ]
> TEST: Non-existing trap action [ OK ]
> TEST: Trap statistics [ OK ]
> TEST: Trap group action [ OK ]
> TEST: Non-existing trap group [ OK ]
> TEST: Trap group statistics [ OK ]
> TEST: Trap policer [ OK ]
> TEST: Trap policer binding [ OK ]
> TEST: Port delete [ OK ]
> TEST: Device delete [ OK ]
This can be in the commit message
> ---
> drivers/net/netdevsim/dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index d85521989753..aad5e3d4a2b6 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -269,7 +269,7 @@ static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev)
> err = PTR_ERR(nsim_dev->nodes_ddir);
> goto err_out;
> }
> - debugfs_create_bool("fail_trap_counter_get", 0600,
> + debugfs_create_bool("fail_trap_drop_counter_get", 0600,
> nsim_dev->ddir,
> &nsim_dev->fail_trap_counter_get);
Please change the name of the variable to match the name of the
corresponding debugfs file
> nsim_udp_tunnels_debugfs_create(nsim_dev);
> --
> 2.17.1
>
prev parent reply other threads:[~2021-06-17 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:34 [PATCH net-next] drivers: net: netdevsim: fix devlink_trap selftests failing Oleksandr Mazur
2021-06-17 6:39 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMruL84N3A3yq1qy@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=vadym.kochan@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).