From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
Hyun Kwon <hyun.kwon@xilinx.com>, Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1]
Date: Wed, 23 Jun 2021 15:59:04 +0300 [thread overview]
Message-ID: <YNMwGICbXY2pWhwn@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ef7cde6f793bfa6f3dd0a8898bad13b6407479b0.1624446456.git.michal.simek@xilinx.com>
On Wed, Jun 23, 2021 at 01:07:38PM +0200, Michal Simek wrote:
> Use proper spacing for array calculation. Issue is reported by
> checkpatch.pl --strict.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 0b67083c95d0..b280a53e8570 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -531,7 +531,7 @@ static void xilinx_dpdma_sw_desc_set_dma_addrs(struct xilinx_dpdma_device *xdev,
> for (i = 1; i < num_src_addr; i++) {
> u32 *addr = &hw_desc->src_addr2;
>
> - addr[i-1] = lower_32_bits(dma_addr[i]);
> + addr[i - 1] = lower_32_bits(dma_addr[i]);
I don't mind either way.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> if (xdev->ext_addr) {
> u32 *addr_ext = &hw_desc->addr_ext_23;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-06-23 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 11:07 [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1] Michal Simek
2021-06-23 12:59 ` Laurent Pinchart [this message]
2021-06-24 11:10 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNMwGICbXY2pWhwn@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dmaengine@vger.kernel.org \
--cc=git@xilinx.com \
--cc=hyun.kwon@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).